[webkit-changes] [WebKit/WebKit] 2f6959: Remove PropertyCascade::PropertyType::VariableRefe...

[Antti Koivisto]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2f6959fb1324843c1d0d16153ff806cf57d899e8
      https://github.com/WebKit/WebKit/commit/2f6959fb1324843c1d0d16153ff806cf57d899e8
  Author: Antti Koivisto <antti at apple.com>
  Date:   2024-01-12 (Fri, 12 Jan 2024)

  Changed paths:
    M Source/WebCore/rendering/style/RenderStyle.cpp
    M Source/WebCore/rendering/style/RenderStyle.h
    M Source/WebCore/style/MatchedDeclarationsCache.cpp
    M Source/WebCore/style/MatchedDeclarationsCache.h
    M Source/WebCore/style/PropertyCascade.cpp
    M Source/WebCore/style/PropertyCascade.h
    M Source/WebCore/style/StyleResolver.cpp

  Log Message:
  -----------
  Remove PropertyCascade::PropertyType::VariableReference
https://bugs.webkit.org/show_bug.cgi?id=267447
rdar://120892359

Reviewed by Ryosuke Niwa.

We have an optimization where the cascade only applies properties containing variable references.
This doesn't seem to be helpful in practice so remove it.

* Source/WebCore/rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::inheritedCustomPropertiesEqual const): Deleted.

This was only needed for this optimization.

* Source/WebCore/rendering/style/RenderStyle.h:
* Source/WebCore/style/MatchedDeclarationsCache.cpp:
(WebCore::Style::MatchedDeclarationsCache::computeHash):
(WebCore::Style::MatchedDeclarationsCache::find):
* Source/WebCore/style/MatchedDeclarationsCache.h:
* Source/WebCore/style/PropertyCascade.cpp:
(WebCore::Style::PropertyCascade::addMatch):
* Source/WebCore/style/PropertyCascade.h:
* Source/WebCore/style/StyleResolver.cpp:
(WebCore::Style::Resolver::applyMatchedProperties):

Canonical link: https://commits.webkit.org/272963@main