[webkit-changes] [WebKit/WebKit] c32281: Reduce use of downcast<>() in rendering code

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c3228161cb7c2728db4b2e648037649df2ebca2f
      https://github.com/WebKit/WebKit/commit/c3228161cb7c2728db4b2e648037649df2ebca2f
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2024-01-11 (Thu, 11 Jan 2024)

  Changed paths:
    M Source/WebCore/rendering/RenderObject.cpp
    M Source/WebCore/rendering/RenderProgress.cpp
    M Source/WebCore/rendering/RenderQuote.cpp
    M Source/WebCore/rendering/RenderReplaced.cpp
    M Source/WebCore/rendering/RenderRubyBase.cpp
    M Source/WebCore/rendering/RenderSelectionGeometry.cpp
    M Source/WebCore/rendering/RenderTable.cpp
    M Source/WebCore/rendering/RenderTableCell.cpp
    M Source/WebCore/rendering/RenderTableCol.cpp
    M Source/WebCore/rendering/RenderTableSection.cpp
    M Source/WebCore/rendering/RenderText.cpp
    M Source/WebCore/rendering/RenderTextControlMultiLine.cpp
    M Source/WebCore/rendering/RenderTextControlSingleLine.h
    M Source/WebCore/rendering/RenderTextFragment.h
    M Source/WebCore/rendering/RenderTheme.cpp
    M Source/WebCore/rendering/RenderTreeAsText.cpp
    M Source/WebCore/rendering/RenderView.cpp
    M Source/WebCore/rendering/RenderWidget.cpp
    M Source/WebCore/rendering/TextAutoSizing.cpp
    M Source/WebCore/rendering/TextDecorationPainter.cpp

  Log Message:
  -----------
  Reduce use of downcast<>() in rendering code
https://bugs.webkit.org/show_bug.cgi?id=267310

Reviewed by Darin Adler.

Reduce use of downcast<>() in rendering code. Prefer dynamicDowncast<>().

* Source/WebCore/rendering/RenderObject.cpp:
(WebCore::RenderObject::setFragmentedFlowStateIncludingDescendants):
(WebCore::RenderObject::resetFragmentedFlowStateOnRemoval):
(WebCore::RenderObject::clearNeedsLayout):
(WebCore::scheduleRelayoutForSubtree):
(WebCore::RenderObject::checkBlockPositionedObjectsNeedLayout):
(WebCore::RenderObject::containingBlock const):
(WebCore::RenderObject::addAbsoluteRectForLayer):
(WebCore::RenderObject::paintingRootRect):
(WebCore::canRelyOnAncestorLayerFullRepaint):
(WebCore::RenderObject::propagateRepaintToParentWithOutlineAutoIfNeeded const):
(WebCore::RenderObject::showLineTreeForThis const):
(WebCore::enclosingFragmentedFlowFromRenderer):
(WebCore::RenderObject::outputRegionsInformation const):
(WebCore::RenderObject::outputRenderObject const):
(WebCore::RenderObject::outputRenderSubTreeAndMark const):
(WebCore::RenderObject::mapLocalToContainer const):
(WebCore::RenderObject::pushMappingToContainer const):
(WebCore::RenderObject::mapAbsoluteToLocalPoint const):
(WebCore::RenderObject::offsetFromContainer const):
(WebCore::containerForElement):
(WebCore::RenderObject::destroy):
(WebCore::RenderObject::absoluteTextRects):
(WebCore::borderAndTextRects):
* Source/WebCore/rendering/RenderProgress.cpp:
(WebCore::RenderProgress::progressElement const):
* Source/WebCore/rendering/RenderQuote.cpp:
(WebCore::RenderQuote::updateTextRenderer):
(WebCore::quoteTextRenderer): Deleted.
* Source/WebCore/rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::computeAspectRatioInformationForRenderBox const):
* Source/WebCore/rendering/RenderRubyBase.cpp:
(WebCore::RenderRubyBase::isEmptyOrHasInFlowContent const):
* Source/WebCore/rendering/RenderSelectionGeometry.cpp:
(WebCore::RenderSelectionGeometry::RenderSelectionGeometry):
* Source/WebCore/rendering/RenderTable.cpp:
(WebCore::RenderTable::layout):
(WebCore::RenderTable::firstColumn const):
(WebCore::RenderTable::recalcSections const):
(WebCore::RenderTable::sectionAbove const):
(WebCore::RenderTable::sectionBelow const):
(WebCore::RenderTable::bottomSection const):
(WebCore::RenderTable::nodeAtPoint):
* Source/WebCore/rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::parseColSpanFromDOM const):
(WebCore::RenderTableCell::parseRowSpanFromDOM const):
* Source/WebCore/rendering/RenderTableCol.cpp:
(WebCore::RenderTableCol::enclosingColumnGroup const):
(WebCore::RenderTableCol::nextColumn const):
* Source/WebCore/rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::relayoutCellIfFlexed):
* Source/WebCore/rendering/RenderText.cpp:
(WebCore::selectionRectForTextBox):
(WebCore::boundariesForTextBox):
(WebCore::combineTextWidth):
(WebCore::isInlineFlowOrEmptyText):
(WebCore::RenderText::previousCharacter const):
(WebCore::RenderText::emphasisMarkExistsAndIsAbove):
* Source/WebCore/rendering/RenderTextControlMultiLine.cpp:
(WebCore::RenderTextControlMultiLine::layoutExcludedChildren):
* Source/WebCore/rendering/RenderTextControlSingleLine.h:
* Source/WebCore/rendering/RenderTextFragment.h:
(isType):
* Source/WebCore/rendering/RenderTheme.cpp:
(WebCore::updateSliderTrackPartForRenderer):
(WebCore::RenderTheme::updateControlPartForRenderer const):
* Source/WebCore/rendering/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::paintMenuListButtonDecorations):
* Source/WebCore/rendering/RenderTreeAsText.cpp:
(WebCore::isEmptyOrUnstyledAppleStyleSpan):
(WebCore::isRenderInlineEmpty):
(WebCore::hasNonEmptySibling):
(WebCore::RenderTreeAsText::writeRenderObject):
(WebCore::writeDebugInfo):
(WebCore::write):
(WebCore::markerTextForListItem):
* Source/WebCore/rendering/RenderView.cpp:
(WebCore::RenderView::rendererForRootBackground const):
* Source/WebCore/rendering/RenderWidget.cpp:
(WebCore::RenderWidget::paintContents):
(WebCore::RenderWidget::paint):
(WebCore::RenderWidget::updateWidgetPosition):
(WebCore::RenderWidget::nodeAtPoint):
(WebCore::RenderWidget::embeddedContentBox const):
* Source/WebCore/rendering/TextAutoSizing.cpp:
(WebCore::TextAutoSizingValue::adjustTextNodeSizes):
* Source/WebCore/rendering/TextDecorationPainter.cpp:
(WebCore::collectStylesForRenderer):

Canonical link: https://commits.webkit.org/272954@main