[webkit-changes] [WebKit/WebKit] 62752b: [GStreamer][WebRTC] WPT test RTCPeerConnection-res...

Philippe Normand noreply at github.com
Thu Jan 11 02:46:47 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 62752b330f81968002532e9220981a6899f10d86
      https://github.com/WebKit/WebKit/commit/62752b330f81968002532e9220981a6899f10d86
  Author: Philippe Normand <philn at igalia.com>
  Date:   2024-01-11 (Thu, 11 Jan 2024)

  Changed paths:
    M Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp

  Log Message:
  -----------
  [GStreamer][WebRTC] WPT test RTCPeerConnection-restartIce.https.html is crashing
https://bugs.webkit.org/show_bug.cgi?id=267328

Reviewed by Xabier Rodriguez-Calvar.

Exit early from restartIce() in case there is no pipeline, addressing the crash. Also remove the
code triggering a new offer, that's not going to be sufficient, and is actually triggering ASSERTs
in Debug builds.
* Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp:
(WebCore::GStreamerMediaEndpoint::restartIce):

Canonical link: https://commits.webkit.org/272909@main




More information about the webkit-changes mailing list