[webkit-changes] [WebKit/WebKit] b46da8: [WGSL] shader, execution, expression, call, builtin, re...

Tadeu Zagallo noreply at github.com
Thu Jan 11 00:57:16 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b46da8564c99c99859b8b4b4ead8386ac785b69c
      https://github.com/WebKit/WebKit/commit/b46da8564c99c99859b8b4b4ead8386ac785b69c
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2024-01-11 (Thu, 11 Jan 2024)

  Changed paths:
    M Source/WebGPU/WGSL/ConstantFunctions.h

  Log Message:
  -----------
  [WGSL] shader,execution,expression,call,builtin,reverseBits:* is failing
https://bugs.webkit.org/show_bug.cgi?id=267345
rdar://120784629

Reviewed by Mike Wyrzykowski.

Fix a couple issues in the bit shifting logic of the constant function.
- The mask to check if a bit is set was missing a bit shift and just using (31 - k)
- The result of checking if the bit is set needs to be converted into 0|1, we
  were using the actual set bit instead.

* Source/WebGPU/WGSL/ConstantFunctions.h:
(WGSL::UNARY_OPERATION):

Canonical link: https://commits.webkit.org/272904@main




More information about the webkit-changes mailing list