[webkit-changes] [WebKit/WebKit] fc2ee1: [WGSL] shader, execution, expression, call, builtin, ro...
Tadeu Zagallo
noreply at github.com
Thu Jan 11 00:51:06 PST 2024
- Previous message (by thread): [webkit-changes] [WebKit/WebKit] 9939b7: [WGSL] shader, execution, expression, call, builtin, re...
- Next message (by thread): [webkit-changes] [WebKit/WebKit] 2539d5: [WGSL] shader, execution, expression, call, builtin, si...
- Messages sorted by:
[ date ]
[ thread ]
[ subject ]
[ author ]
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: fc2ee18b7d41347711cde7de48a6e99888ddbde0
https://github.com/WebKit/WebKit/commit/fc2ee18b7d41347711cde7de48a6e99888ddbde0
Author: Tadeu Zagallo <tzagallo at apple.com>
Date: 2024-01-11 (Thu, 11 Jan 2024)
Changed paths:
M Source/WebGPU/WGSL/ConstantFunctions.h
M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp
Log Message:
-----------
[WGSL] shader,execution,expression,call,builtin,round:* is failing
https://bugs.webkit.org/show_bug.cgi?id=267343
rdar://120784372
Reviewed by Mike Wyrzykowski.
Both the constant and runtime version of round were incorrect. The constant version
failed for negative with a .5 fractional part and the runtime version was using
Metal's `round`, which doesn't not match WGSL's behavior. Instead we use rint for
both.
* Source/WebGPU/WGSL/ConstantFunctions.h:
* Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp:
(WGSL::Metal::FunctionDefinitionWriter::visit):
Canonical link: https://commits.webkit.org/272902@main
- Previous message (by thread): [webkit-changes] [WebKit/WebKit] 9939b7: [WGSL] shader, execution, expression, call, builtin, re...
- Next message (by thread): [webkit-changes] [WebKit/WebKit] 2539d5: [WGSL] shader, execution, expression, call, builtin, si...
- Messages sorted by:
[ date ]
[ thread ]
[ subject ]
[ author ]
More information about the webkit-changes
mailing list