[webkit-changes] [WebKit/WebKit] 167dc5: EventTarget shouldn't have a special case for whee...

Ryosuke Niwa noreply at github.com
Wed Jan 10 23:48:20 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 167dc5118a3f6228a19df40e673ea0a6d03b9bec
      https://github.com/WebKit/WebKit/commit/167dc5118a3f6228a19df40e673ea0a6d03b9bec
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2024-01-10 (Wed, 10 Jan 2024)

  Changed paths:
    M Source/WebCore/dom/Document.cpp
    M Source/WebCore/dom/EventTarget.cpp
    M Source/WebCore/dom/EventTarget.h
    M Source/WebCore/dom/Node.cpp
    M Source/WebCore/page/LocalDOMWindow.cpp

  Log Message:
  -----------
  EventTarget shouldn't have a special case for wheel events
https://bugs.webkit.org/show_bug.cgi?id=267383

Reviewed by Yusuke Suzuki.

Move the code to invalidate event regions for wheel events from EventTarget to DOMWindow and Node.
Note that Node::removeAllEventListeners is only called when Document::removeAllEventListeners is
called in Document::~Document or Document::open so clearing it in Document::removeAllEventListeners
is sufficient.

* Source/WebCore/dom/Document.cpp:
(WebCore::Document::removeAllEventListeners):
* Source/WebCore/dom/EventTarget.cpp:
(WebCore::EventTarget::addEventListener):
(WebCore::EventTarget::removeEventListener):
(WebCore::EventTarget::removeAllEventListeners):
(WebCore::EventTarget::invalidateEventListenerRegions): Deleted.
* Source/WebCore/dom/EventTarget.h:
* Source/WebCore/dom/Node.cpp:
(WebCore::tryAddEventListener):
(WebCore::tryRemoveEventListener):
* Source/WebCore/page/LocalDOMWindow.cpp:
(WebCore::LocalDOMWindow::addEventListener):
(WebCore::LocalDOMWindow::removeEventListener):

Canonical link: https://commits.webkit.org/272895@main




More information about the webkit-changes mailing list