[webkit-changes] [WebKit/WebKit] 819e12: Remove Element.scrollByLines() and Element.scrollB...

[Karl Dubost]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 819e12af49a3d44661f118eda128fe30fc5c4a72
      https://github.com/WebKit/WebKit/commit/819e12af49a3d44661f118eda128fe30fc5c4a72
  Author: Karl Dubost <karlcow at apple.com>
  Date:   2024-01-10 (Wed, 10 Jan 2024)

  Changed paths:
    R LayoutTests/fast/css/element-scrollByLines-scrollByPages-obsolete-expected.txt
    R LayoutTests/fast/css/element-scrollByLines-scrollByPages-obsolete.html
    M LayoutTests/webgl/2.0.0/resources/webgl_test_files/deqp/temp_externs/gecko_dom.js
    M Source/WebCore/dom/Element.cpp
    M Source/WebCore/dom/Element.h
    M Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElementGtk.cpp
    M Source/WebKitLegacy/mac/DOM/DOMElement.h
    M Source/WebKitLegacy/mac/DOM/DOMElement.mm

  Log Message:
  -----------
  Remove Element.scrollByLines() and Element.scrollByPages()
https://bugs.webkit.org/show_bug.cgi?id=264732
rdar://118647942

Reviewed by Simon Fraser and Dan Glastonbury.

Chromium removed this code in 2014. It seems that there is no internal
dependencies on these features.
Thanks to Anne van Kesteren for giving a better understanding of what
needed to be done.

* LayoutTests/fast/css/element-scrollByLines-scrollByPages-obsolete-expected.txt: Removed.
* LayoutTests/fast/css/element-scrollByLines-scrollByPages-obsolete.html: Removed.
* LayoutTests/webgl/2.0.0/resources/webgl_test_files/deqp/temp_externs/gecko_dom.js:
* Source/WebCore/dom/Element.cpp:
(WebCore::Element::scrollByUnits): Deleted.
(WebCore::Element::scrollByLines): Deleted.
(WebCore::Element::scrollByPages): Deleted.
* Source/WebCore/dom/Element.h:
* Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElementGtk.cpp:
(webkit_dom_element_scroll_by_lines): Made the function no-op.
(webkit_dom_element_scroll_by_pages): Made the function no-op.
* Source/WebKitLegacy/mac/DOM/DOMElement.h: Moved the definitions to the deprecated section.
* Source/WebKitLegacy/mac/DOM/DOMElement.mm: Made the function no-op and moved them to the deprecated section.
(-[DOMElement scrollByLines:]):
(-[DOMElement scrollByPages:]):

Canonical link: https://commits.webkit.org/272881@main