[webkit-changes] [WebKit/WebKit] c0d19c: Disable building XPC services when launching WebKi...

Per Arne Vollan noreply at github.com
Wed Jan 10 14:30:59 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c0d19cb34e3a93e3e4bdba390db548dc5ab51fe9
      https://github.com/WebKit/WebKit/commit/c0d19cb34e3a93e3e4bdba390db548dc5ab51fe9
  Author: Per Arne Vollan <pvollan at apple.com>
  Date:   2024-01-10 (Wed, 10 Jan 2024)

  Changed paths:
    M Source/WebKit/Configurations/BaseExtension.xcconfig
    M Source/WebKit/Configurations/BaseXPCService.xcconfig
    M Source/WebKit/Configurations/GPUExtension.xcconfig
    M Source/WebKit/Configurations/GPUService.xcconfig
    M Source/WebKit/Configurations/NetworkService.xcconfig
    M Source/WebKit/Configurations/NetworkingExtension.xcconfig
    M Source/WebKit/Configurations/WebContentCaptivePortalExtension.xcconfig
    M Source/WebKit/Configurations/WebContentExtension.xcconfig
    M Source/WebKit/Configurations/WebContentService.xcconfig
    M Source/WebKit/Scripts/copy-webcontent-resources-to-private-headers.sh
    M Source/WebKit/Shared/AuxiliaryProcessExtensions/GPUExtension-Info.plist
    M Source/WebKit/Shared/AuxiliaryProcessExtensions/NetworkingExtension-Info.plist
    M Source/WebKit/Shared/AuxiliaryProcessExtensions/WebContentExtension-CaptivePortal-Info.plist
    M Source/WebKit/Shared/AuxiliaryProcessExtensions/WebContentExtension-Info.plist
    M Source/WebKit/UIProcess/Launcher/ProcessLauncher.h
    M Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj

  Log Message:
  -----------
  Disable building XPC services when launching WebKit processes as extensions
https://bugs.webkit.org/show_bug.cgi?id=267248
rdar://120677588

Reviewed by Elliott Williams and Brent Fulgham.

Disable building XPC services when launching WebKit processes as extensions. Additonally, this patch
is changing the bundle ID of the extensions to match the XPC service bundle IDs. This is to ensure
that existing bundle ID checks will continue to work. Also disable fallback to XPC service launch,
since these are not being built anymore. Instead, a temporary fallback using the old bundle IDs is
added, since the bundle IDs are normally cached on the system until they are re-registered.

* Source/WebKit/Configurations/BaseExtension.xcconfig:
* Source/WebKit/Configurations/BaseXPCService.xcconfig:
* Source/WebKit/Configurations/GPUExtension.xcconfig:
* Source/WebKit/Configurations/GPUService.xcconfig:
* Source/WebKit/Configurations/NetworkService.xcconfig:
* Source/WebKit/Configurations/NetworkingExtension.xcconfig:
* Source/WebKit/Configurations/WebContentCaptivePortalExtension.xcconfig:
* Source/WebKit/Configurations/WebContentExtension.xcconfig:
* Source/WebKit/Configurations/WebContentService.xcconfig:
* Source/WebKit/UIProcess/Launcher/ProcessLauncher.h:
(WebKit::ProcessLauncher::setIsRetryingLaunch):
(WebKit::ProcessLauncher::isRetryingLaunch const):
* Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm:
(WebKit::serviceNameAndIdentifier):
(WebKit::launchWithExtensionKit):
(WebKit::ProcessLauncher::launchProcess):
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/Scripts/copy-webcontent-resources-to-private-headers.sh:

Canonical link: https://commits.webkit.org/272868@main




More information about the webkit-changes mailing list