[webkit-changes] [WebKit/WebKit] fcfe0a: Variadic params to callbacks aren't handled correctly

Luke Warlow noreply at github.com
Wed Jan 10 12:10:10 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fcfe0a54117d8eb309a3c1285e5cbd09585b290f
      https://github.com/WebKit/WebKit/commit/fcfe0a54117d8eb309a3c1285e5cbd09585b290f
  Author: Luke Warlow <lwarlow at igalia.com>
  Date:   2024-01-10 (Wed, 10 Jan 2024)

  Changed paths:
    M Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
    A Source/WebCore/bindings/scripts/test/JS/JSTestCallbackFunctionWithVariadic.cpp
    A Source/WebCore/bindings/scripts/test/JS/JSTestCallbackFunctionWithVariadic.h
    M Source/WebCore/bindings/scripts/test/SupplementalDependencies.dep
    A Source/WebCore/bindings/scripts/test/TestCallbackFunctionWithVariadic.idl

  Log Message:
  -----------
  Variadic params to callbacks aren't handled correctly
https://bugs.webkit.org/show_bug.cgi?id=267332

Reviewed by Chris Dumez.

Updates code generator to handle variadic params to callbacks.

* Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:
(GenerateCallbackHeaderContent):
(GenerateCallbackImplementationContent):
* Source/WebCore/bindings/scripts/test/JS/JSTestCallbackFunctionWithVariadic.cpp: Added.
(WebCore::JSTestCallbackFunctionWithVariadic::JSTestCallbackFunctionWithVariadic):
(WebCore::JSTestCallbackFunctionWithVariadic::~JSTestCallbackFunctionWithVariadic):
(WebCore::JSTestCallbackFunctionWithVariadic::handleEvent):
(WebCore::toJS):
* Source/WebCore/bindings/scripts/test/JS/JSTestCallbackFunctionWithVariadic.h: Added.
(WebCore::toJS):
* Source/WebCore/bindings/scripts/test/SupplementalDependencies.dep:
* Source/WebCore/bindings/scripts/test/TestCallbackFunctionWithVariadic.idl: Added.

Canonical link: https://commits.webkit.org/272855@main




More information about the webkit-changes mailing list