[webkit-changes] [WebKit/WebKit] 839528: [iFC][Ruby] frameset with display:none crashes in ...

[Antti Koivisto]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8395281e9b922d0a61ca44f141c9374cabc6fcc6
      https://github.com/WebKit/WebKit/commit/8395281e9b922d0a61ca44f141c9374cabc6fcc6
  Author: Antti Koivisto <antti at apple.com>
  Date:   2024-01-10 (Wed, 10 Jan 2024)

  Changed paths:
    A LayoutTests/fast/ruby/ruby-frameset-display-none-crash-expected.txt
    A LayoutTests/fast/ruby/ruby-frameset-display-none-crash.html
    M Source/WebCore/html/HTMLFrameElement.cpp
    M Source/WebCore/html/HTMLFrameSetElement.cpp
    M Source/WebCore/html/HTMLFrameSetElement.h
    M Source/WebCore/style/StyleAdjuster.cpp

  Log Message:
  -----------
  [iFC][Ruby] frameset with display:none crashes in ruby
https://bugs.webkit.org/show_bug.cgi?id=267331
rdar://120496400

Reviewed by Alan Baradlay.

<frameset> generates a renderer even with 'display:none' breaking some assumptions.

* LayoutTests/fast/ruby/ruby-frameset-display-none-crash-expected.txt: Added.
* LayoutTests/fast/ruby/ruby-frameset-display-none-crash.html: Added.
* Source/WebCore/html/HTMLFrameElement.cpp:
(WebCore::HTMLFrameElement::rendererIsNeeded):
* Source/WebCore/html/HTMLFrameSetElement.cpp:
(WebCore::HTMLFrameSetElement::rendererIsNeeded): Deleted.
* Source/WebCore/html/HTMLFrameSetElement.h:
* Source/WebCore/style/StyleAdjuster.cpp:
(WebCore::Style::Adjuster::adjust const):

Adjust frameset/frame always have 'display:block', even when it is orginally 'none'.
This matches other browsers.

Canonical link: https://commits.webkit.org/272846@main