[webkit-changes] [WebKit/WebKit] 3505bb: [Win] REGRESSION(272822 at main): StreamClientConnect...

[Fujii Hironori]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3505bb0973f997dc1e1ae8cde963887e29d6b8cd
      https://github.com/WebKit/WebKit/commit/3505bb0973f997dc1e1ae8cde963887e29d6b8cd
  Author: Fujii Hironori <Hironori.Fujii at sony.com>
  Date:   2024-01-09 (Tue, 09 Jan 2024)

  Changed paths:
    M Source/WebCore/testing/Internals.cpp
    M Source/WebCore/testing/Internals.h
    M Source/WebKit/Platform/IPC/Connection.h

  Log Message:
  -----------
  [Win] REGRESSION(272822 at main): StreamClientConnection.h(216,20): error: call to implicitly-deleted copy constructor of 'StreamClientConnection::SendSyncResult<PrepareForDisplay>'
https://bugs.webkit.org/show_bug.cgi?id=267294
rdar://120756511

Reviewed by Alex Christensen.

Fujii suggested this fix, and I initially thought I could do better by modifying WTF::Expected,
but after looking at it for a few hours, I'm not sure why MSVC doesn't see the move constructor.
Soon we'll have std::expected and this will hopefully not be an issue.

Also move a NO_RETURN_DUE_TO_CRASH macro to make MSVC happy.

* Source/WTF/wtf/Expected.h:
(std::experimental::fundamentals_v3::__expected_detail::constexpr_base::constexpr_base):
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::terminateWebContentProcess):
* Source/WebCore/testing/Internals.h:

Canonical link: https://commits.webkit.org/272842@main