[webkit-changes] [WebKit/WebKit] b316ee: Skip cross-origin check when serializing CSSStyleS...

Sihui noreply at github.com
Tue Jan 9 11:14:57 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b316eede4c277fc080049cbaca25b51c577d38ec
      https://github.com/WebKit/WebKit/commit/b316eede4c277fc080049cbaca25b51c577d38ec
  Author: Sihui Liu <sihui_liu at apple.com>
  Date:   2024-01-09 (Tue, 09 Jan 2024)

  Changed paths:
    M Source/WebCore/css/CSSStyleSheet.cpp
    M Source/WebCore/css/CSSStyleSheet.h
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/CreateWebArchive.mm

  Log Message:
  -----------
  Skip cross-origin check when serializing CSSStyleSheet for saving
https://bugs.webkit.org/show_bug.cgi?id=267140
rdar://120490524

Reviewed by Ryosuke Niwa and BJ Burg.

CSSStyleSheet::cssRules() can be invoked via Web API, so it performs cross-origin check for security.
CSSStyleSheet::cssTextWithReplacementURLs() is only used for archiving style sheet now (initiated by client), so we
should skip cross-origin check to ensure content is correctly preserved. This patch adds allCSSRules() for that.

API Test: WebArchive.SaveResourcesCrossOriginLink

* Source/WebCore/css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::cssRules):
(WebCore::CSSStyleSheet::cssRulesSkippingAccessCheck):
(WebCore::CSSStyleSheet::cssTextWithReplacementURLs):
* Source/WebCore/css/CSSStyleSheet.h:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/CreateWebArchive.mm:

Canonical link: https://commits.webkit.org/272823@main




More information about the webkit-changes mailing list