[webkit-changes] [WebKit/WebKit] ee0b8e: `:has-attachment` pseudo-class should be prefixed

Tim Nguyen noreply at github.com
Tue Jan 9 08:15:20 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ee0b8ecdb38dbf2891eaf5844f5214540d43f703
      https://github.com/WebKit/WebKit/commit/ee0b8ecdb38dbf2891eaf5844f5214540d43f703
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2024-01-09 (Tue, 09 Jan 2024)

  Changed paths:
    A LayoutTests/fast/attachment/has-attachment-pseudo-class-expected.txt
    A LayoutTests/fast/attachment/has-attachment-pseudo-class.html
    R LayoutTests/fast/css/has-attachment-expected.txt
    R LayoutTests/fast/css/has-attachment.html
    M LayoutTests/platform/glib/TestExpectations
    M LayoutTests/platform/wincairo/TestExpectations
    M LayoutTests/platform/wpe/TestExpectations
    M Source/WebCore/css/CSSPseudoSelectors.json
    M Source/WebCore/css/SelectorChecker.cpp
    M Source/WebCore/cssjit/SelectorCompiler.cpp

  Log Message:
  -----------
  `:has-attachment` pseudo-class should be prefixed
https://bugs.webkit.org/show_bug.cgi?id=266948
rdar://120599170

Reviewed by Darin Adler.

This pseudo-class is only used by the Apple Mail apps along with the <attachment> element feature.

Prefix it with `-apple-` to make this clear and subject to validation for `-apple-` prefixes.

* LayoutTests/fast/attachment/has-attachment-pseudo-class-expected.txt: Renamed from LayoutTests/fast/css/has-attachment-expected.txt.
* LayoutTests/fast/attachment/has-attachment-pseudo-class.html: Renamed from LayoutTests/fast/css/has-attachment.html.
* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/platform/wincairo/TestExpectations:
* LayoutTests/platform/wpe/TestExpectations:

Move test to the fast/attachment directory which is already skipped on relevant platforms.

* Source/WebCore/css/CSSPseudoSelectors.json:
* Source/WebCore/css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne const):
* Source/WebCore/cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::addPseudoClassType):

Canonical link: https://commits.webkit.org/272820@main




More information about the webkit-changes mailing list