[webkit-changes] [WebKit/WebKit] 4c2711: [IFC][Geometry] Remove BoxGeometry's logical/visua...

Alan Baradlay noreply at github.com
Tue Jan 9 06:37:54 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4c2711daa540509fc7cfb1a5bcbc3c6732e73dad
      https://github.com/WebKit/WebKit/commit/4c2711daa540509fc7cfb1a5bcbc3c6732e73dad
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-01-09 (Tue, 09 Jan 2024)

  Changed paths:
    M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp
    M Source/WebCore/layout/layouttree/LayoutBoxGeometry.cpp
    M Source/WebCore/layout/layouttree/LayoutBoxGeometry.h

  Log Message:
  -----------
  [IFC][Geometry] Remove BoxGeometry's logical/visual conversion helpers
https://bugs.webkit.org/show_bug.cgi?id=267202

Reviewed by Antti Koivisto.

Since BoxGeometry is supposed to be always logical, let's not have visual related helpers on it.

* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::toMarginAndBorderBoxVisualRect):
(WebCore::LayoutIntegration::LineLayout::updateRenderTreePositions):
* Source/WebCore/layout/layouttree/LayoutBoxGeometry.cpp:
(WebCore::Layout::BoxGeometry::toVisualGeometry const): Deleted.
(WebCore::Layout::BoxGeometry::toLogicalGeometry const): Deleted.
* Source/WebCore/layout/layouttree/LayoutBoxGeometry.h:

Canonical link: https://commits.webkit.org/272815@main




More information about the webkit-changes mailing list