[webkit-changes] [WebKit/WebKit] d1cf37: [WGSL] Fix typos in tests and add extra validation...

Tadeu Zagallo noreply at github.com
Tue Jan 9 04:15:56 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d1cf373824a82d210a44371b4f701ce2b89073ed
      https://github.com/WebKit/WebKit/commit/d1cf373824a82d210a44371b4f701ce2b89073ed
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2024-01-09 (Tue, 09 Jan 2024)

  Changed paths:
    M Source/WebGPU/WGSL/tests/lit.cfg
    M Source/WebGPU/WGSL/tests/valid/overload.wgsl
    M Source/WebGPU/WGSL/wgslc.cpp

  Log Message:
  -----------
  [WGSL] Fix typos in tests and add extra validation to wgslc
https://bugs.webkit.org/show_bug.cgi?id=267227
rdar://120647630

Reviewed by Mike Wyrzykowski.

In two instances there was a typo in the entrypoint name being passed to wgslc,
meaning that no code was actually being generated, so the metal test was no-op.
I added some extra validation to wgslc to ensure that the entrypoint exists, while
keeping the special case for `_`, which is currently used for tests that only care
about the type checking, so there's no need to generate code.

* Source/WebGPU/WGSL/tests/lit.cfg:
* Source/WebGPU/WGSL/tests/valid/overload.wgsl:
* Source/WebGPU/WGSL/wgslc.cpp:
(runWGSL):

Canonical link: https://commits.webkit.org/272812@main




More information about the webkit-changes mailing list