[webkit-changes] [WebKit/WebKit] 9ab872: [WebGPU] api/validation/render_pass/resolve is fai...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9ab872aa65af14e90f1ca4d366fa08f280593ab9
      https://github.com/WebKit/WebKit/commit/9ab872aa65af14e90f1ca4d366fa08f280593ab9
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-01-08 (Mon, 08 Jan 2024)

  Changed paths:
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/render_pass/render_pass_descriptor-expected.txt
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/render_pass/resolve-expected.txt
    M Source/WebCore/Modules/WebGPU/GPUComputePassTimestampWrites.h
    M Source/WebCore/Modules/WebGPU/GPURenderPassDepthStencilAttachment.h
    M Source/WebCore/Modules/WebGPU/GPURenderPassDepthStencilAttachment.idl
    M Source/WebCore/Modules/WebGPU/GPURenderPassTimestampWrites.h
    M Source/WebCore/Modules/WebGPU/Implementation/WebGPUCommandEncoderImpl.cpp
    M Source/WebGPU/WebGPU/CommandEncoder.h
    M Source/WebGPU/WebGPU/CommandEncoder.mm
    M Source/WebGPU/WebGPU/ComputePassEncoder.mm
    M Source/WebGPU/WebGPU/QuerySet.h
    M Source/WebGPU/WebGPU/QuerySet.mm
    M Source/WebGPU/WebGPU/Queue.h
    M Source/WebGPU/WebGPU/Queue.mm
    M Source/WebGPU/WebGPU/RenderPassEncoder.h
    M Source/WebGPU/WebGPU/RenderPassEncoder.mm
    M Source/WebGPU/WebGPU/RenderPipeline.h
    M Source/WebGPU/WebGPU/RenderPipeline.mm
    M Source/WebGPU/WebGPU/Texture.h
    M Source/WebGPU/WebGPU/Texture.mm
    M Source/WebGPU/WebGPU/TextureView.h
    M Source/WebGPU/WebGPU/TextureView.mm

  Log Message:
  -----------
  [WebGPU] api/validation/render_pass/resolve is failing
https://bugs.webkit.org/show_bug.cgi?id=267024
<radar://120400053>

Reviewed by Tadeu Zagallo.

Add validation and passing expectations for api/validation/render_pass/render_pass_descriptor
and api/validation/render_pass/resolve which both pass after these changes.

* LayoutTests/http/tests/webgpu/webgpu/api/validation/render_pass/render_pass_descriptor-expected.txt:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/render_pass/resolve-expected.txt:
* Source/WebCore/Modules/WebGPU/GPUComputePassTimestampWrites.h:
* Source/WebCore/Modules/WebGPU/GPURenderPassDepthStencilAttachment.h:
(WebCore::GPURenderPassDepthStencilAttachment::convertToBacking const):
* Source/WebCore/Modules/WebGPU/GPURenderPassDepthStencilAttachment.idl:
* Source/WebCore/Modules/WebGPU/GPURenderPassTimestampWrites.h:
* Source/WebCore/Modules/WebGPU/Implementation/WebGPUCommandEncoderImpl.cpp:
(WebCore::WebGPU::CommandEncoderImpl::beginRenderPass):
* Source/WebGPU/WebGPU/CommandEncoder.h:
(WebGPU::CommandEncoder::makeInvalid): Deleted.
* Source/WebGPU/WebGPU/CommandEncoder.mm:
(WebGPU::Device::createCommandEncoder):
(WebGPU::CommandEncoder::ensureBlitCommandEncoder):
(WebGPU::timestampWriteIndex):
(WebGPU::validateTimestampWrites):
(WebGPU::CommandEncoder::validateComputePassDescriptor const):
(WebGPU::CommandEncoder::beginComputePass):
(WebGPU::CommandEncoder::validateRenderPassDescriptor const):
(WebGPU::createSimplePso):
(WebGPU::CommandEncoder::runClearEncoder):
(WebGPU::isMultisampleTexture):
(WebGPU::isRenderableTextureView):
(WebGPU::CommandEncoder::beginRenderPass):
(WebGPU::CommandEncoder::makeInvalid):
(WebGPU::CommandEncoder::finish):
* Source/WebGPU/WebGPU/Device.h:
* Source/WebGPU/WebGPU/Device.mm:
(WebGPU::Device::create):
(WebGPU::Device::setUnusedCommandBuffer):
* Source/WebGPU/WebGPU/QuerySet.h:
* Source/WebGPU/WebGPU/QuerySet.mm:
(WebGPU::Device::createQuerySet):
* Source/WebGPU/WebGPU/RenderPassEncoder.h:
(WebGPU::RenderPassEncoder::create):
(WebGPU::RenderPassEncoder::createInvalid):
* Source/WebGPU/WebGPU/RenderPassEncoder.mm:
(WebGPU::RenderPassEncoder::RenderPassEncoder):
(WebGPU::RenderPassEncoder::endPass):
(WebGPU::RenderPassEncoder::makeInvalid):
(WebGPU::RenderPassEncoder::setPipeline):
(WebGPU::RenderPassEncoder::setScissorRect):
* Source/WebGPU/WebGPU/RenderPipeline.h:
(WebGPU::RenderPipeline::create):
* Source/WebGPU/WebGPU/RenderPipeline.mm:
(WebGPU::Device::createRenderPipeline):
(WebGPU::RenderPipeline::RenderPipeline):
(WebGPU::RenderPipeline::colorTargetsMatch const):
(WebGPU::RenderPipeline::depthAttachmentMatches const):
(WebGPU::RenderPipeline::stencilAttachmentMatches const):
* Source/WebGPU/WebGPU/Texture.h:
* Source/WebGPU/WebGPU/Texture.mm:
(WebGPU::Texture::isColorRenderableFormat):
(WebGPU::Texture::isDepthStencilRenderableFormat):
(WebGPU::Texture::supportsResolve):
(WebGPU::Texture::createView):
(WebGPU::Texture::destroy):
(WebGPU::Texture::recreateIfNeeded): Deleted.
(WebGPU::Texture::makeCanvasBacking): Deleted.
* Source/WebGPU/WebGPU/TextureView.h:
* Source/WebGPU/WebGPU/TextureView.mm:
(WebGPU::TextureView::parentTexture const):
(WebGPU::TextureView::width const):
(WebGPU::TextureView::height const):
(WebGPU::TextureView::parentFormat const):
(WebGPU::TextureView::format const):
(WebGPU::TextureView::parentMipLevelCount const):
(WebGPU::TextureView::mipLevelCount const):
(WebGPU::TextureView::baseMipLevel const):
(WebGPU::TextureView::aspect const):
(WebGPU::TextureView::arrayLayerCount const):
(WebGPU::TextureView::baseArrayLayer const):
(WebGPU::TextureView::dimension const):

Canonical link: https://commits.webkit.org/272798@main