[webkit-changes] [WebKit/WebKit] 131472: Apple.com: Apple Events Video captions not working

[danae404]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1314723e5732e1168a7bd6501cfa3295b54879b5
      https://github.com/WebKit/WebKit/commit/1314723e5732e1168a7bd6501cfa3295b54879b5
  Author: Dana Estra <destra at apple.com>
  Date:   2024-01-08 (Mon, 08 Jan 2024)

  Changed paths:
    M Source/WebCore/platform/graphics/AudioTrackPrivate.h
    M Source/WebCore/platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.h
    M Source/WebCore/platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm

  Log Message:
  -----------
  Apple.com: Apple Events Video captions not working
https://bugs.webkit.org/show_bug.cgi?id=267160
rdar://119839950

Reviewed by Jer Noble.

Currently, when an HLS video on the web has multiple text tracks to choose from, only the last
one in the list functions. This is because all of the text tracks have the same track ID, and
therefore override each other. They all have the same track ID because
InbandTextTrackPrivateAVFObjC does not override TrackPrivateBase's virtual id() function, and
so it always returns the default value 0.

To fix this, InbandTextTrackPrivateAVFObjC now implements id().

* Source/WebCore/platform/graphics/AudioTrackPrivate.h:
(WebCore::AudioTrackPrivate::create): Deleted.
* Source/WebCore/platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.h:
* Source/WebCore/platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm:
(WebCore::InbandTextTrackPrivateAVFObjC::id const):

Canonical link: https://commits.webkit.org/272784@main