[webkit-changes] [WebKit/WebKit] 1fdb92: [GStreamer] imported/w3c/web-platform-tests/webaud...

Philippe Normand noreply at github.com
Mon Jan 8 07:43:10 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1fdb9251bb08acd8bd5ee06c652684cb9d4c9740
      https://github.com/WebKit/WebKit/commit/1fdb9251bb08acd8bd5ee06c652684cb9d4c9740
  Author: Philippe Normand <philn at igalia.com>
  Date:   2024-01-08 (Mon, 08 Jan 2024)

  Changed paths:
    M LayoutTests/platform/glib/TestExpectations
    M Source/WebCore/platform/audio/gstreamer/AudioDestinationGStreamer.cpp
    M Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp
    M Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.h

  Log Message:
  -----------
  [GStreamer] imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioworklet-interface/audioworklet-registerprocessor-called-on-globalthis.https is flaky crash
https://bugs.webkit.org/show_bug.cgi?id=264934

Reviewed by Xabier Rodriguez-Calvar.

Store the AudioBus as a RefPtr in the GStreamer weaudiosrc element. Using a raw pointer provided no
guarantee the underlying data was still valid.

* LayoutTests/platform/glib/TestExpectations:
* Source/WebCore/platform/audio/gstreamer/AudioDestinationGStreamer.cpp:
(WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):
* Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
(webkit_web_audio_src_class_init):
(webKitWebAudioSrcConstructed):
(webKitWebAudioSrcSetProperty):
(webKitWebAudioSrcGetProperty):
(webKitWebAudioSrcRenderAndPushFrames):
(webkitWebAudioSourceSetBus):
* Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.h:

Canonical link: https://commits.webkit.org/272761@main




More information about the webkit-changes mailing list