[webkit-changes] [WebKit/WebKit] 1e3966: Update/Remove tests relying on 'getPropertyCSSValue'

Ahmad Saleem noreply at github.com
Mon Jan 8 03:00:04 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1e3966d2e89c2d1356ee89cd1de68c2daa150f63
      https://github.com/WebKit/WebKit/commit/1e3966d2e89c2d1356ee89cd1de68c2daa150f63
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2024-01-08 (Mon, 08 Jan 2024)

  Changed paths:
    M LayoutTests/animations/fill-mode-iteration-count-non-integer.html
    M LayoutTests/animations/fill-mode-missing-from-to-keyframes.html
    M LayoutTests/animations/fill-mode-multiple-keyframes.html
    M LayoutTests/animations/fill-mode-removed.html
    M LayoutTests/animations/fill-mode.html
    M LayoutTests/css3/blending/background-blend-mode-property-parsing-expected.txt
    M LayoutTests/css3/blending/background-blend-mode-property-parsing.html
    M LayoutTests/css3/blending/blend-mode-property-parsing-expected.txt
    M LayoutTests/css3/blending/blend-mode-property-parsing.html
    M LayoutTests/css3/calc/reflection-computed-style-expected.txt
    M LayoutTests/css3/calc/reflection-computed-style.html
    M LayoutTests/css3/filters/filter-property-computed-style-expected.txt
    M LayoutTests/css3/filters/filter-property-computed-style.html
    M LayoutTests/css3/filters/filter-property-parsing-expected.txt
    M LayoutTests/css3/filters/filter-property-parsing.html
    M LayoutTests/fast/css/custom-font-xheight.html
    M LayoutTests/fast/css/sheet-collection-link.html
    M LayoutTests/fast/css/style-enumerate-properties-expected.txt
    M LayoutTests/fast/css/style-enumerate-properties.html
    M LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-color-expected.txt
    M LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-color.html
    M LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line-expected.txt
    M LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line.html
    M LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-style-expected.txt
    M LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-style.html
    M LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-underline-position-expected.txt
    M LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-underline-position.html
    M LayoutTests/fast/dom/css-element-attribute-js-null-expected.txt
    M LayoutTests/fast/dom/css-element-attribute-js-null.html
    M LayoutTests/fast/dom/dom-constructors-expected.txt
    M LayoutTests/fast/dom/dom-constructors.html
    M LayoutTests/fast/dom/domListEnumeration-expected.txt
    M LayoutTests/fast/dom/domListEnumeration.html
    M LayoutTests/fast/dom/gc-9-expected.txt
    M LayoutTests/fast/dom/gc-9.html
    M LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt
    M LayoutTests/fast/dom/non-numeric-values-numeric-parameters.html
    M LayoutTests/fast/dom/prototypes-expected.txt
    M LayoutTests/fast/dom/prototypes.html
    M LayoutTests/fast/dom/wrapper-classes-expected.txt
    M LayoutTests/fast/dom/wrapper-classes.html
    M LayoutTests/fast/history/visited-generated-content-test.html
    M LayoutTests/fast/media/mq-js-update-media.html
    M LayoutTests/fast/reflections/reflection-computed-style-expected.txt
    M LayoutTests/fast/reflections/reflection-computed-style.html
    R LayoutTests/http/tests/security/contentSecurityPolicy/inline-style-allowed-while-cloning-objects-expected.txt
    R LayoutTests/http/tests/security/contentSecurityPolicy/inline-style-allowed-while-cloning-objects.html
    M LayoutTests/platform/mac/fast/dom/objc-wrapper-identity-expected.txt
    M LayoutTests/platform/mac/fast/dom/objc-wrapper-identity.html
    M LayoutTests/svg/animations/animate-color-rgba-calcMode-discrete-expected.txt
    M LayoutTests/svg/animations/animate-color-rgba-calcMode-discrete.html
    M LayoutTests/svg/animations/change-css-property-while-animating-fill-freeze-expected.txt
    M LayoutTests/svg/animations/change-css-property-while-animating-fill-freeze.html
    M LayoutTests/svg/animations/change-css-property-while-animating-fill-remove-expected.txt
    M LayoutTests/svg/animations/change-css-property-while-animating-fill-remove.html
    M LayoutTests/svg/css/getComputedStyle-basic-expected.txt
    M LayoutTests/svg/css/getComputedStyle-basic.xhtml
    M LayoutTests/svg/css/glyph-orientation-rounding-test-expected.txt
    M LayoutTests/svg/css/glyph-orientation-rounding-test.xhtml
    M LayoutTests/svg/css/rect-system-color.xhtml
    M LayoutTests/svg/transforms/transform-origin-presentation-attribute.xhtml

  Log Message:
  -----------
  Update/Remove tests relying on 'getPropertyCSSValue'

https://bugs.webkit.org/show_bug.cgi?id=229912

Reviewed by Tim Nguyen.

This PR is to update tests relying on historical 'CSS' properties and make it easier to remove them in future.

Selective Merge: https://chromium.googlesource.com/chromium/blink/+/018db695b2fd41eccdf23a87f157611f0425465d ,
https://chromium.googlesource.com/chromium/blink/+/088bcb0bb1fc92f4144303a6650fcdccaacac5f9 ,
https://chromium.googlesource.com/chromium/blink/+/16138b933dbebe3e3570464c8e3cf01d530f2bcd ,
https://chromium.googlesource.com/chromium/blink/+/839bdc83ee530f8b972f4195587995a7bda22368 ,
https://chromium.googlesource.com/chromium/blink/+/47b9403fd8b928a324d35a71566548ce6592568a ,
https://chromium.googlesource.com/chromium/blink/+/98d37e56283bb920a7ec652ea9235f8f5fd87a7a ,
https://chromium.googlesource.com/chromium/blink/+/ab1811d8bf4e7fa18f9c6fa44e5a86bb7b2f7d17 ,
https://chromium.googlesource.com/chromium/blink/+/391870c98875dcff621ab992553ebf9f4f695012 ,
https://chromium.googlesource.com/chromium/blink/+/42fab77317a1ba7b9b91225c64460fff932d6312 ,
https://chromium.googlesource.com/chromium/blink/+/d264cf786c1b2a87f99e095e09ea00bb85ee4e69 ,
https://chromium.googlesource.com/chromium/blink/+/2c7a5a8bf7d3f37e0af669bb241886e3aceffbfb and
https://chromium.googlesource.com/chromium/blink/+/b179bc4d8475adc7943745c6cabe6997202577dc

> Rebaselined Tests & Expectations:
* LayoutTests/animations/fill-mode-iteration-count-non-integer.html:
* LayoutTests/animations/fill-mode-missing-from-to-keyframes.html:
* LayoutTests/animations/fill-mode-multiple-keyframes.html:
* LayoutTests/animations/fill-mode-removed.html:
* LayoutTests/animations/fill-mode.html:
* LayoutTests/css3/blending/background-blend-mode-property-parsing.html:
* LayoutTests/css3/blending/background-blend-mode-property-parsing-expected.txt:
* LayoutTests/css3/blending/blend-mode-property-parsing.html:
* LayoutTests/css3/blending/blend-mode-property-parsing-expected.txt:
* LayoutTests/css3/calc/reflection-computed-style.html:
* LayoutTests/css3/calc/reflection-computed-style-expected.txt:
* LayoutTests/css3/filters/filter-property-parsing.html:
* LayoutTests/css3/filters/filter-property-parsing-expected.txt:
* LayoutTests/css3/filters/filter-property-computed-style.html:
* LayoutTests/css3/filters/filter-property-computed-style-expected.txt:
* LayoutTests/fast/css/custom-font-xheight.html:
* LayoutTests/fast/css/sheet-collection-link.html:
* LayoutTests/fast/css/style-enumerate-properties.html:
* LayoutTests/fast/css/style-enumerate-properties-expected.txt:
* LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-color.html:
* LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-color-expected.txt:
* LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line.html:
* LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line-expected.txt:
* LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-style.html;
* LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-style-expected.txt:
* LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-underline-position.html:
* LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-underline-position-expected.txt:
* LayoutTests/fast/dom/css-element-attribute-js-null.html:
* LayoutTests/fast/dom/css-element-attribute-js-null-expected.txt:
* LayoutTests/fast/dom/dom-constructors-expected.txt:
* LayoutTests/fast/dom/dom-constructors.html:
* LayoutTests/fast/dom/domListEnumeration.html:
* LayoutTests/fast/dom/domListEnumeration-expected.txt:
* LayoutTests/fast/dom/gc-9.html:
* LayoutTests/fast/dom/gc-9-expected.txt:
* LayoutTests/fast/dom/non-numeric-values-numeric-parameters.html:
* LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt:
* LayoutTests/fast/dom/prototypes.html:
* LayoutTests/fast/dom/prototypes-expected.txt:
* LayoutTests/fast/dom/wrapper-classes.html:
* LayoutTests/fast/dom/wrapper-classes-expected.txt:
* LayoutTests/fast/history/visited-generated-content-test.html:
* LayoutTests/fast/media/mq-js-update-media.html:
* LayoutTests/fast/reflections/reflection-computed-style.html:
* LayoutTests/fast/reflections/reflection-computed-style-expected.txt:
* LayoutTests/platform/mac/fast/dom/objc-wrapper-identity.html: Just ‘js-test’ update
* LayoutTests/platform/mac/fast/dom/objc-wrapper-identity-expected.txt: Just ‘js-test’ update
* LayoutTests/svg/animations/animate-color-rgba-calcMode-discrete.html:
* LayoutTests/svg/animations/animate-color-rgba-calcMode-discrete-expected.txt:
* LayoutTests/svg/animations/change-css-property-while-animating-fill-freeze.html:
* LayoutTests/svg/animations/change-css-property-while-animating-fill-freeze-expected.txt:
* LayoutTests/svg/animations/change-css-property-while-animating-fill-remove.html:
* LayoutTests/svg/animations/change-css-property-while-animating-fill-remove-expected.txt:
* LayoutTests/svg/css/getComputedStyle-basic.xhtml:
* LayoutTests/svg/css/getComputedStyle-basic-expected.txt:
* LayoutTests/svg/css/glyph-orientation-rounding-test.xhtml:
* LayoutTests/svg/css/glyph-orientation-rounding-test-expected.txt:
* LayoutTests/svg/css/rect-system-color.xhtml:
* LayoutTests/svg/transforms/transform-origin-presentation-attribute.xhtml:

> Deleted Tests:
* LayoutTests/http/tests/security/contentSecurityPolicy/inline-style-allowed-while-cloning-objects.html: Deleted in favour of WPT Test
* LayoutTests/http/tests/security/contentSecurityPolicy/inline-style-allowed-while-cloning-objects-expected.txt: Ditto

Canonical link: https://commits.webkit.org/272756@main




More information about the webkit-changes mailing list