[webkit-changes] [WebKit/WebKit] 5a57b4: Revert removal of else branch in SelectorChecker::...

[Anne van Kesteren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5a57b47cbfbb4edbeeb22b65c1e91847f633bf47
      https://github.com/WebKit/WebKit/commit/5a57b47cbfbb4edbeeb22b65c1e91847f633bf47
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2024-01-06 (Sat, 06 Jan 2024)

  Changed paths:
    M Source/WebCore/css/SelectorChecker.cpp

  Log Message:
  -----------
  Revert removal of else branch in SelectorChecker::matchRecursively()
https://bugs.webkit.org/show_bug.cgi?id=267184

Reviewed by Tim Nguyen.

272726 at main (re-landed as 272729 at main) removed the else branch under
the assumption that all paths had early returns. But that is not the
case. E.g., a user agent shadow root containing an element with a
matching pseudo attribute.

While I'm not sure how to cover this with a test and no tests
regressed, it seems best to restore the status quo prior to that
commit.

* Source/WebCore/css/SelectorChecker.cpp:
(WebCore::SelectorChecker::matchRecursively const):

Canonical link: https://commits.webkit.org/272738@main