[webkit-changes] [WebKit/WebKit] 3cd087: Clean-up process-css-pseudo-selectors.py

Tim Nguyen noreply at github.com
Fri Jan 5 18:50:43 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3cd087d87fd5299b8c7f544ff2d377decfbc408e
      https://github.com/WebKit/WebKit/commit/3cd087d87fd5299b8c7f544ff2d377decfbc408e
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2024-01-05 (Fri, 05 Jan 2024)

  Changed paths:
    M Source/WebCore/CMakeLists.txt
    M Source/WebCore/DerivedSources.make
    M Source/WebCore/css/CSSPseudoSelectors.json
    M Source/WebCore/css/CSSSelector.h
    M Source/WebCore/css/parser/MutableCSSSelector.cpp
    M Source/WebCore/css/process-css-pseudo-selectors.py

  Log Message:
  -----------
  Clean-up process-css-pseudo-selectors.py
https://bugs.webkit.org/show_bug.cgi?id=267152
rdar://120560220

Reviewed by Ryosuke Niwa.

- Fix copyright header indentation and remove new line before it.
- Use f-strings instead of ''.format() for readability
- Use dictionary.get() whenever possible when filling in default values for missing keys
- Make argument parsing more similar to process-css-properties.py and process-css-values.py
- Rename "condition" to "conditional" to match other files
- Rename "ShadowPseudoElement" to "UserAgentPart"

* Source/WebCore/CMakeLists.txt:
* Source/WebCore/DerivedSources.make:
* Source/WebCore/css/CSSPseudoSelectors.json:
* Source/WebCore/css/CSSSelector.h:
* Source/WebCore/css/parser/MutableCSSSelector.cpp:
(WebCore::MutableCSSSelector::parsePseudoElementSelector):
* Source/WebCore/css/process-css-pseudo-selectors.py:
(InputValidator.check_field_documentation):
(InputValidator.validate_fields):
(write_copyright_header):

Canonical link: https://commits.webkit.org/272720@main




More information about the webkit-changes mailing list