[webkit-changes] [WebKit/WebKit] 343cc5: Make ENABLE_DATE_AND_TIME_INPUT_TYPES a standalone...

Anne van Kesteren noreply at github.com
Fri Jan 5 09:02:43 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 343cc5f09fe4b4f594809a4b4634fcb65f2d03d4
      https://github.com/WebKit/WebKit/commit/343cc5f09fe4b4f594809a4b4634fcb65f2d03d4
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2024-01-05 (Fri, 05 Jan 2024)

  Changed paths:
    R LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/form-controls/resets-expected.txt
    M LayoutTests/platform/gtk/fast/forms/date/date-input-rendering-basic-expected.txt
    M LayoutTests/platform/gtk/fast/forms/date/date-pseudo-elements-expected.txt
    M LayoutTests/platform/gtk/fast/forms/time/time-input-rendering-basic-expected.txt
    R LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/form-controls/resets-expected.txt
    M Source/WTF/wtf/PlatformEnable.h
    M Source/WTF/wtf/PlatformEnableCocoa.h
    M Source/cmake/OptionsGTK.cmake
    M Source/cmake/OptionsMac.cmake
    M Source/cmake/WebKitFeatures.cmake

  Log Message:
  -----------
  Make ENABLE_DATE_AND_TIME_INPUT_TYPES a standalone directive
https://bugs.webkit.org/show_bug.cgi?id=267123

Reviewed by Michael Catanzaro.

If it's not a feature it won't end up in scripts that generate C++, as
seen here: https://bugs.webkit.org/show_bug.cgi?id=266947

Furthermore, it not being a feature also caused GTK to ignore a
conditional in html.css. This corrects that and rebases the tests,
creating some more alignment across ports.

As pointed out in https://bugs.webkit.org/show_bug.cgi?id=267080 this
problem is likely to reoccur and might well still be present for other
directives.

* LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/form-controls/resets-expected.txt: Removed.
* LayoutTests/platform/gtk/fast/forms/date/date-input-rendering-basic-expected.txt:
* LayoutTests/platform/gtk/fast/forms/date/date-pseudo-elements-expected.txt:
* LayoutTests/platform/gtk/fast/forms/time/time-input-rendering-basic-expected.txt:
* LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/form-controls/resets-expected.txt: Removed.
* Source/WTF/wtf/PlatformEnable.h:
* Source/WTF/wtf/PlatformEnableCocoa.h:
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsMac.cmake:
* Source/cmake/WebKitFeatures.cmake:

Canonical link: https://commits.webkit.org/272689@main




More information about the webkit-changes mailing list