[webkit-changes] [WebKit/WebKit] b5c493: [WebGPU] dynamic bind group indices continue to be...
mwyrzykowski
noreply at github.com
Fri Jan 5 07:48:11 PST 2024
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b5c493976ba54c2bcbfa55c8b7b329226fb67af9
https://github.com/WebKit/WebKit/commit/b5c493976ba54c2bcbfa55c8b7b329226fb67af9
Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
Date: 2024-01-05 (Fri, 05 Jan 2024)
Changed paths:
M Source/WebGPU/WebGPU/BindGroupLayout.h
M Source/WebGPU/WebGPU/BindGroupLayout.mm
M Source/WebGPU/WebGPU/PipelineLayout.mm
Log Message:
-----------
[WebGPU] dynamic bind group indices continue to be incorrect
https://bugs.webkit.org/show_bug.cgi?id=267119
<radar://120510255>
Reviewed by Tadeu Zagallo.
The copy in PipelineLayout assumed the bind group
indices were linearly increasing but this was not guaranteed as
they were stored in a HashMap.
Build a shadow sorted container to address this as the data does
not change after creation.
* Source/WebGPU/WebGPU/BindGroupLayout.h:
* Source/WebGPU/WebGPU/BindGroupLayout.mm:
(WebGPU::Device::createBindGroupLayout):
This was being sorted uncessarily each iteration, correct this.
(WebGPU::BindGroupLayout::BindGroupLayout):
(WebGPU:: const):
* Source/WebGPU/WebGPU/PipelineLayout.mm:
(WebGPU::PipelineLayout::offsetVectorForBindGroup):
Canonical link: https://commits.webkit.org/272687@main
More information about the webkit-changes
mailing list