[webkit-changes] [WebKit/WebKit] 2cf55f: [iOS] Remove unbalanced call to `-[WKWebView _endA...

Aditya Keerthi noreply at github.com
Fri Jan 5 00:52:14 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2cf55f042f34ca24769a0465587790f169a712e4
      https://github.com/WebKit/WebKit/commit/2cf55f042f34ca24769a0465587790f169a712e4
  Author: Aditya Keerthi <akeerthi at apple.com>
  Date:   2024-01-05 (Fri, 05 Jan 2024)

  Changed paths:
    M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm

  Log Message:
  -----------
  [iOS] Remove unbalanced call to `-[WKWebView _endAnimatedResize]` in `WKFullScreenViewController`
https://bugs.webkit.org/show_bug.cgi?id=267109
rdar://120501189

Reviewed by Wenson Hsieh.

270199 at main removed a call to `-[WKWebView _beginAnimatedResizeWithUpdates:]`
when performing the fullscreen transition animation, but did not remove the
associated call to `-[WKWebView _endAnimatedResize]`.

This is currently benign since, `_endAnimatedResize` is a no-op if an animated
resize is not in progress. However, it is dangerous, since it could end an
animated resize started elsewhere. To avoid this pitfall, the unbalanced call
is removed.

* Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm:
(-[WKFullScreenViewController viewWillTransitionToSize:withTransitionCoordinator:]):

Canonical link: https://commits.webkit.org/272680@main




More information about the webkit-changes mailing list