[webkit-changes] [WebKit/WebKit] 8862bd: [WebGPU] CTS validation/render_pipeline/inter_stag...
mwyrzykowski
noreply at github.com
Thu Jan 4 22:13:26 PST 2024
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8862bd5e4aa728799a7396116a071b6af15ed18a
https://github.com/WebKit/WebKit/commit/8862bd5e4aa728799a7396116a071b6af15ed18a
Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
Date: 2024-01-04 (Thu, 04 Jan 2024)
Changed paths:
M LayoutTests/http/tests/webgpu/webgpu/api/validation/render_pipeline/inter_stage-expected.txt
M Source/WebGPU/WGSL/Parser.cpp
M Source/WebGPU/WGSL/WGSLShaderModule.h
M Source/WebGPU/WebGPU/RenderPipeline.mm
M Source/WebGPU/WebGPU/ShaderModule.h
M Source/WebGPU/WebGPU/ShaderModule.mm
Log Message:
-----------
[WebGPU] CTS validation/render_pipeline/inter_stage.html is failing
https://bugs.webkit.org/show_bug.cgi?id=266733
<radar://119958254>
Reviewed by Tadeu Zagallo.
Add validation for vertex-fragment interstage and add passing
exepctations now that all render_pipeline/* are passing.
* LayoutTests/http/tests/webgpu/webgpu/api/validation/render_pipeline/inter_stage-expected.txt:
* Source/WebGPU/WGSL/Parser.cpp:
(WGSL::Parser<Lexer>::parseAttribute):
* Source/WebGPU/WGSL/WGSLShaderModule.h:
(WGSL::ShaderModule::usesFrontFacing const):
(WGSL::ShaderModule::setUsesFrontFacing):
(WGSL::ShaderModule::usesSampleIndex const):
(WGSL::ShaderModule::setUsesSampleIndex):
* Source/WebGPU/WebGPU/RenderPipeline.mm:
(WebGPU::componentsForDataType):
(WebGPU::errorValidatingInterstageShaderInterfaces):
(WebGPU::Device::createRenderPipeline):
* Source/WebGPU/WebGPU/ShaderModule.h:
* Source/WebGPU/WebGPU/ShaderModule.mm:
(WebGPU::parseFragmentReturnType):
(WebGPU::parseVertexReturnType):
(WebGPU::populateFragmentInputs):
(WebGPU::parseFragmentInputs):
(WebGPU::ShaderModule::ShaderModule):
(WebGPU::ShaderModule::fragmentInputsForEntryPoint const):
(WebGPU::ShaderModule::fragmentReturnTypeForEntryPoint const):
(WebGPU::ShaderModule::vertexReturnTypeForEntryPoint const):
(WebGPU::parseReturnType): Deleted.
(WebGPU::ShaderModule::returnTypeForEntryPoint const): Deleted.
Canonical link: https://commits.webkit.org/272674@main
More information about the webkit-changes
mailing list