[webkit-changes] [WebKit/WebKit] 4a02d7: Make most CSSSelector setters only available to Mu...

[Tim Nguyen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4a02d79b3e9c11ebe226d266f3527c1a3929d0ed
      https://github.com/WebKit/WebKit/commit/4a02d79b3e9c11ebe226d266f3527c1a3929d0ed
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2024-01-03 (Wed, 03 Jan 2024)

  Changed paths:
    M Source/WebCore/css/CSSSelector.h
    M Source/WebCore/css/parser/CSSParserImpl.cpp
    M Source/WebCore/css/parser/MutableCSSSelector.h

  Log Message:
  -----------
  Make most CSSSelector setters only available to MutableCSSSelector
https://bugs.webkit.org/show_bug.cgi?id=267060
rdar://120434084

Reviewed by Simon Fraser.

CSSSelector isn't meant to be mutated in the majority of cases, restrict most setters to MutableCSSSelector.

* Source/WebCore/css/CSSSelector.h:
(WebCore::CSSSelector::hasDescendantRelation const):
(WebCore::CSSSelector::relation const):
(WebCore::CSSSelector::match const):
(WebCore::CSSSelector::isLastInSelectorList const):
(WebCore::CSSSelector::isFirstInTagHistory const):
(WebCore::CSSSelector::setLastInSelectorList):
(WebCore::CSSSelector::setNotFirstInTagHistory):
(WebCore::CSSSelector::setNotLastInTagHistory):
(WebCore::CSSSelector::isForPage const):
(WebCore::CSSSelector::setForPage):
(WebCore::CSSSelector::setImplicit):
(WebCore::CSSSelector::tagHistory):
(WebCore::CSSSelector::setNotLastInSelectorList): Deleted.
(WebCore::CSSSelector::setLastInTagHistory): Deleted.
* Source/WebCore/css/parser/CSSParserImpl.cpp:
(WebCore::appendImplicitSelectorPseudoClassScopeIfNeeded):
(WebCore::CSSParserImpl::createNestingParentRule):
* Source/WebCore/css/parser/MutableCSSSelector.h:
(WebCore::MutableCSSSelector::setImplicit):

Canonical link: https://commits.webkit.org/272635@main