[webkit-changes] [WebKit/WebKit] 572fec: Disable AES-CFB.

Commit Queue noreply at github.com
Wed Jan 3 10:16:46 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 572fec1979ec18aa50fda2389fc9768459851535
      https://github.com/WebKit/WebKit/commit/572fec1979ec18aa50fda2389fc9768459851535
  Author: nmahendru <nitinmahendru at apple.com>
  Date:   2024-01-03 (Wed, 03 Jan 2024)

  Changed paths:
    M LayoutTests/crypto/subtle/aes-cbc-cfb-decrypt-malformed-parameters.html
    M LayoutTests/crypto/subtle/aes-cbc-cfb-encrypt-malformed-parameters.html
    M LayoutTests/crypto/subtle/aes-cfb-generate-export-key-jwk-length-128.html
    M LayoutTests/crypto/subtle/aes-cfb-generate-export-key-jwk-length-192.html
    M LayoutTests/crypto/subtle/aes-cfb-generate-export-key-jwk-length-256.html
    M LayoutTests/crypto/subtle/aes-cfb-generate-export-raw-key.html
    M LayoutTests/crypto/subtle/aes-cfb-generate-key-encrypt-decrypt.html
    M LayoutTests/crypto/subtle/aes-cfb-generate-key.html
    M LayoutTests/crypto/subtle/aes-cfb-import-jwk-key-length-128.html
    M LayoutTests/crypto/subtle/aes-cfb-import-jwk-key-length-192.html
    M LayoutTests/crypto/subtle/aes-cfb-import-jwk-key-length-256.html
    M LayoutTests/crypto/subtle/aes-cfb-import-key-decrypt.html
    M LayoutTests/crypto/subtle/aes-cfb-import-key-encrypt.html
    M LayoutTests/crypto/subtle/aes-cfb-import-key-unwrap-jwk-key.html
    M LayoutTests/crypto/subtle/aes-cfb-import-key-unwrap-raw-key.html
    M LayoutTests/crypto/subtle/aes-cfb-import-key-wrap-jwk-key.html
    M LayoutTests/crypto/subtle/aes-cfb-import-key-wrap-raw-key.html
    M LayoutTests/crypto/subtle/aes-cfb-import-raw-key.html
    M LayoutTests/crypto/subtle/aes-export-key-malformed-parameters.html
    M LayoutTests/crypto/subtle/aes-generate-key-malformed-parameters.html
    M LayoutTests/crypto/subtle/aes-import-key-malformed-parameters.html
    M LayoutTests/crypto/subtle/aes-kw-wrap-key-malformed-parameters.html
    M LayoutTests/crypto/workers/subtle/aes-cfb-import-key-decrypt.html
    M LayoutTests/crypto/workers/subtle/aes-cfb-import-key-encrypt.html
    M LayoutTests/crypto/workers/subtle/aes-cfb-import-key-unwrap-key.html
    M LayoutTests/crypto/workers/subtle/aes-cfb-import-key-wrap-key.html
    M LayoutTests/crypto/workers/subtle/aes-ctr-import-key-decrypt.html
    M LayoutTests/crypto/workers/subtle/resources/aes-cfb-import-key-unwrap-key.js
    M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
    M Source/WebCore/crypto/SubtleCrypto.cpp

  Log Message:
  -----------
  Disable AES-CFB.
https://bugs.webkit.org/show_bug.cgi?id=266990
radar://120000331

Reviewed by Pascoe.

It's been removed from the standard since 2016.
This change will disable AES-CFB by default.
Following the same pattern as:
https://github.com/WebKit/WebKit/pull/8392

* LayoutTests/crypto/subtle/aes-cbc-cfb-decrypt-malformed-parameters.html:
* LayoutTests/crypto/subtle/aes-cbc-cfb-encrypt-malformed-parameters.html:
* LayoutTests/crypto/subtle/aes-cfb-generate-export-key-jwk-length-128.html:
* LayoutTests/crypto/subtle/aes-cfb-generate-export-key-jwk-length-192.html:
* LayoutTests/crypto/subtle/aes-cfb-generate-export-key-jwk-length-256.html:
* LayoutTests/crypto/subtle/aes-cfb-generate-export-raw-key.html:
* LayoutTests/crypto/subtle/aes-cfb-generate-key-encrypt-decrypt.html:
* LayoutTests/crypto/subtle/aes-cfb-generate-key.html:
* LayoutTests/crypto/subtle/aes-cfb-import-jwk-key-length-128.html:
* LayoutTests/crypto/subtle/aes-cfb-import-jwk-key-length-192.html:
* LayoutTests/crypto/subtle/aes-cfb-import-jwk-key-length-256.html:
* LayoutTests/crypto/subtle/aes-cfb-import-key-decrypt.html:
* LayoutTests/crypto/subtle/aes-cfb-import-key-encrypt.html:
* LayoutTests/crypto/subtle/aes-cfb-import-key-unwrap-jwk-key.html:
* LayoutTests/crypto/subtle/aes-cfb-import-key-unwrap-raw-key.html:
* LayoutTests/crypto/subtle/aes-cfb-import-key-wrap-jwk-key.html:
* LayoutTests/crypto/subtle/aes-cfb-import-raw-key.html:
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/crypto/SubtleCrypto.cpp:
(WebCore::isAESCFBWebCryptoDeprecated):
(WebCore::normalizeCryptoAlgorithmParameters):
(WebCore::isSupportedExportKey):

Canonical link: https://commits.webkit.org/272615@main




More information about the webkit-changes mailing list