[webkit-changes] [WebKit/WebKit] a9f625: Remove Element::userAgentPartId() in favor of pseu...

Anne van Kesteren noreply at github.com
Wed Jan 3 02:24:00 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a9f625b0b81f3e6dd73f16c2504a40f58fcec8cf
      https://github.com/WebKit/WebKit/commit/a9f625b0b81f3e6dd73f16c2504a40f58fcec8cf
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2024-01-03 (Wed, 03 Jan 2024)

  Changed paths:
    M Source/WebCore/css/SelectorChecker.cpp
    M Source/WebCore/dom/Element.cpp
    M Source/WebCore/dom/Element.h
    M Source/WebCore/html/TextFieldInputType.cpp
    M Source/WebCore/html/shadow/DateTimeEditElement.cpp
    M Source/WebCore/html/shadow/YouTubeEmbedShadowElement.cpp
    M Source/WebCore/rendering/RenderTheme.cpp
    M Source/WebCore/style/ElementRuleCollector.cpp
    M Source/WebCore/style/StyleAdjuster.cpp
    M Source/WebCore/style/StyleInvalidator.cpp
    M Source/WebCore/style/StyleResolver.cpp
    M Source/WebCore/style/StyleSharingResolver.cpp
    M Source/WebCore/testing/Internals.cpp

  Log Message:
  -----------
  Remove Element::userAgentPartId() in favor of pseudo()
https://bugs.webkit.org/show_bug.cgi?id=267030

Reviewed by Tim Nguyen.

This virtual method was never overridden and didn't do anything beyond
calling pseudo() directly.

Also remove an obsolete include in YouTubeEmbedShadowElement and use
pseudo() instead of directly invoking the attribute getter in
TextFieldInputType.

* Source/WebCore/css/SelectorChecker.cpp:
(WebCore::SelectorChecker::matchRecursively const):
* Source/WebCore/dom/Element.cpp:
(WebCore::Element::userAgentPartId const): Deleted.
* Source/WebCore/dom/Element.h:
* Source/WebCore/html/shadow/DateTimeEditElement.cpp:
(WebCore::DateTimeEditElement::layout):
* Source/WebCore/html/shadow/YouTubeEmbedShadowElement.cpp:
* Source/WebCore/rendering/RenderTheme.cpp:
(WebCore::RenderTheme::autoAppearanceForElement const):
* Source/WebCore/style/ElementRuleCollector.cpp:
(WebCore::Style::ElementRuleCollector::matchPartPseudoElementRules):
(WebCore::Style::ElementRuleCollector::collectMatchingShadowPseudoElementRules):
* Source/WebCore/style/StyleAdjuster.cpp:
(WebCore::Style::Adjuster::adjust const):
* Source/WebCore/style/StyleInvalidator.cpp:
(WebCore::Style::Invalidator::invalidateShadowPseudoElements):
* Source/WebCore/style/StyleResolver.cpp:
(WebCore::Style::elementTypeHasAppearanceFromUAStyle):
* Source/WebCore/style/StyleSharingResolver.cpp:
(WebCore::Style::SharingResolver::canShareStyleWithElement const):
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::userAgentPartId):

Canonical link: https://commits.webkit.org/272604@main




More information about the webkit-changes mailing list