[webkit-changes] [WebKit/WebKit] 94f262: Rename `WebKitCustom` and `WebKitCustomLegacyPrefi...

Tim Nguyen noreply at github.com
Tue Jan 2 19:54:20 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 94f262ba04598cefdff4859e5864c971273348ec
      https://github.com/WebKit/WebKit/commit/94f262ba04598cefdff4859e5864c971273348ec
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2024-01-02 (Tue, 02 Jan 2024)

  Changed paths:
    M Source/WebCore/css/CSSPseudoSelectors.json
    M Source/WebCore/css/CSSSelector.cpp
    M Source/WebCore/css/CSSSelector.h
    M Source/WebCore/css/SelectorChecker.cpp
    M Source/WebCore/css/parser/CSSParserSelector.cpp
    M Source/WebCore/css/parser/CSSParserSelector.h
    M Source/WebCore/css/parser/CSSSelectorParser.cpp
    M Source/WebCore/css/process-css-pseudo-selectors.py
    M Source/WebCore/cssjit/SelectorCompiler.cpp
    M Source/WebCore/style/RuleSet.cpp

  Log Message:
  -----------
  Rename `WebKitCustom` and `WebKitCustomLegacyPrefixed` in `PseudoElement`
https://bugs.webkit.org/show_bug.cgi?id=267016
rdar://120395761

Reviewed by Ryosuke Niwa.

They don't necessarily represent `-webkit-` prefixed things. They just represent elements in UA shadow trees (like ::placeholder, ::file-selector-button, ::thumb or ::track),
which is effectively similar to the functionality ::part() provides in non-UA shadow trees (represented by `PseudoElement::Part`).

- Rename `PseudoElement::WebKitCustom` to `PseudoElement::UserAgentPart`
- Rename `PseudoElement::WebKitCustomLegacyPrefixed` to `PseudoElement::UserAgentPartLegacyAlias`

webkit.org/b/266947 will take care of mapping unknown `-webkit-` pseudo-elements to a different type (`PseudoElement::WebKitUnknown`).

* Source/WebCore/css/CSSPseudoSelectors.json:
* Source/WebCore/css/CSSSelector.cpp:
(WebCore::CSSSelector::pseudoId):
(WebCore::CSSSelector::parsePseudoElement):
* Source/WebCore/css/CSSSelector.h:
(WebCore::CSSSelector::isUserAgentPartPseudoElement const):
(WebCore::CSSSelector::isWebKitCustomPseudoElement const): Deleted.
* Source/WebCore/css/SelectorChecker.cpp:
(WebCore::SelectorChecker::matchRecursively const):
* Source/WebCore/css/parser/CSSParserSelector.cpp:
(WebCore::CSSParserSelector::parsePseudoElementSelector):
* Source/WebCore/css/parser/CSSParserSelector.h:
(WebCore::CSSParserSelector::needsImplicitShadowCombinatorForMatching const):
* Source/WebCore/css/parser/CSSSelectorParser.cpp:
(WebCore::extractCompoundFlags):
(WebCore::isPseudoClassValidAfterPseudoElement):
(WebCore::CSSSelectorParser::consumePseudo):
(WebCore::CSSSelectorParser::containsUnknownWebKitPseudoElements):
* Source/WebCore/css/process-css-pseudo-selectors.py:
* Source/WebCore/cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::constructFragmentsInternal):
* Source/WebCore/style/RuleSet.cpp:
(WebCore::Style::RuleSet::addRule):

Canonical link: https://commits.webkit.org/272593@main




More information about the webkit-changes mailing list