[webkit-changes] [WebKit/WebKit] 3a6204: AX: Adding a symmetric relation is calling AXIsola...

AndresGonzalezApple noreply at github.com
Tue Jan 2 16:21:01 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3a6204e6a89bf8719049bef01f666f582163e202
      https://github.com/WebKit/WebKit/commit/3a6204e6a89bf8719049bef01f666f582163e202
  Author: Andres Gonzalez <andresg_22 at apple.com>
  Date:   2024-01-02 (Tue, 02 Jan 2024)

  Changed paths:
    M Source/WebCore/accessibility/AXObjectCache.cpp

  Log Message:
  -----------
  AX: Adding a symmetric relation is calling AXIsolatedTree::addUnconnectedNode unnecessarily.
https://bugs.webkit.org/show_bug.cgi?id=266982
<rdar://problem/120370690>

Reviewed by Tyler Wilcock.

Follow up to https://bugs.webkit.org/show_bug.cgi?id=266608.

Since adding a symmetric relationship involves the same objects as the initial relation, there is no need to call AXIsolatedTree::addUnconnectedNode for symmetric relations. This addition to update the isolated tree belongs to the addRelation overload that takes AX objects. This patch also adds a check to ensure that the objects being related are still alive when adding a symmetric relationship.

* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::addRelation):

Canonical link: https://commits.webkit.org/272586@main




More information about the webkit-changes mailing list