[webkit-changes] [WebKit/WebKit] 5e996b: [css-grid] Rename GridBaselineAlignment's m_blockF...

[Sammy Gill]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5e996b5167f06a420715b3718bdf05860eaa5b3e
      https://github.com/WebKit/WebKit/commit/5e996b5167f06a420715b3718bdf05860eaa5b3e
  Author: Sammy Gill <sammy.gill at apple.com>
  Date:   2024-01-02 (Tue, 02 Jan 2024)

  Changed paths:
    M Source/WebCore/rendering/GridBaselineAlignment.cpp
    M Source/WebCore/rendering/GridBaselineAlignment.h
    M Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp

  Log Message:
  -----------
  [css-grid] Rename GridBaselineAlignment's m_blockFlow to m_writingMode.
https://bugs.webkit.org/show_bug.cgi?id=266993
rdar://problem/120379902

Reviewed by Tim Nguyen.

This variable refers to the grid's writing mode and not its block flow
direction. We can get the block flow direction from the writing mode,
but we also need to know its writing mode since the spec will use it in
certain scenarions.

See: https://drafts.csswg.org/css-align-3/#baseline-export

* Source/WebCore/rendering/GridBaselineAlignment.cpp:
(WebCore::GridBaselineAlignment::ascentForChild const):
(WebCore::GridBaselineAlignment::isDescentBaselineForChild const):
(WebCore::GridBaselineAlignment::isHorizontalBaselineAxis const):
(WebCore::GridBaselineAlignment::isOrthogonalChildForBaseline const):
* Source/WebCore/rendering/GridBaselineAlignment.h:
(WebCore::GridBaselineAlignment::setWritingMode):
(WebCore::GridBaselineAlignment::setBlockFlow): Deleted.
* Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:
(WebCore::GridTrackSizingAlgorithm::computeBaselineAlignmentContext):

Canonical link: https://commits.webkit.org/272582@main