[webkit-changes] [WebKit/WebKit] d7d735: `HasScope` should not be represented as a `PseudoC...

Tim Nguyen noreply at github.com
Mon Jan 1 07:03:10 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d7d7358f95b5061063be351b493abf41a1daa6b2
      https://github.com/WebKit/WebKit/commit/d7d7358f95b5061063be351b493abf41a1daa6b2
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2024-01-01 (Mon, 01 Jan 2024)

  Changed paths:
    M Source/WebCore/css/CSSSelector.cpp
    M Source/WebCore/css/CSSSelector.h
    M Source/WebCore/css/SelectorChecker.cpp
    M Source/WebCore/css/parser/CSSSelectorParser.cpp
    M Source/WebCore/cssjit/SelectorCompiler.cpp
    M Source/WebCore/style/RuleSet.cpp

  Log Message:
  -----------
  `HasScope` should not be represented as a `PseudoClass` internally
https://bugs.webkit.org/show_bug.cgi?id=266949
rdar://120335193

Reviewed by Darin Adler.

To make auto-generating the PseudoClass enum class from JSON easier, move PseudoClass::HasScope to CSSSelector::Match since it is not actually a pseudo-class even if behaves similarly.

This "pseudo-class" represents the hidden scope in relative selectors like :has(> foo)`.

* Source/WebCore/css/CSSSelector.cpp:
(WebCore::simpleSelectorSpecificity):
(WebCore::CSSSelector::selectorText const):
* Source/WebCore/css/CSSSelector.h:
* Source/WebCore/css/SelectorChecker.cpp:
(WebCore::canMatchHoverOrActiveInQuirksMode):
(WebCore::SelectorChecker::checkOne const):
* Source/WebCore/css/parser/CSSSelectorParser.cpp:
(WebCore::CSSSelectorParser::consumeRelativeScopeSelector):
* Source/WebCore/cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::addPseudoClassType):
(WebCore::SelectorCompiler::constructFragmentsInternal):
* Source/WebCore/style/RuleSet.cpp:
(WebCore::Style::RuleSet::addRule):

Canonical link: https://commits.webkit.org/272554@main




More information about the webkit-changes mailing list