[webkit-changes] [WebKit/WebKit] f8e764: Make pseudo attribute values of DateTimeFieldEleme...

Anne van Kesteren noreply at github.com
Mon Jan 1 02:02:41 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f8e7643db02e7e5c994fedf49333064c659dc2a4
      https://github.com/WebKit/WebKit/commit/f8e7643db02e7e5c994fedf49333064c659dc2a4
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2024-01-01 (Mon, 01 Jan 2024)

  Changed paths:
    M Source/WebCore/html/shadow/DateTimeFieldElement.cpp
    M Source/WebCore/html/shadow/DateTimeFieldElement.h
    M Source/WebCore/html/shadow/DateTimeFieldElements.cpp
    M Source/WebCore/html/shadow/DateTimeNumericFieldElement.cpp
    M Source/WebCore/html/shadow/DateTimeNumericFieldElement.h
    M Source/WebCore/html/shadow/DateTimeSymbolicFieldElement.cpp
    M Source/WebCore/html/shadow/DateTimeSymbolicFieldElement.h
    M Source/WebCore/html/shadow/ShadowPseudoIds.cpp
    M Source/WebCore/html/shadow/ShadowPseudoIds.h

  Log Message:
  -----------
  Make pseudo attribute values of DateTimeFieldElements proper ShadowPseudoIds
https://bugs.webkit.org/show_bug.cgi?id=266951

Reviewed by Tim Nguyen.

This will enable us to have a central source of truth for
ShadowPseudoIds in due course.

Also call setPseudo() directly instead of using a somewhat useless
wrapper.

* Source/WebCore/html/shadow/DateTimeFieldElement.cpp:
(WebCore::DateTimeFieldElement::initialize): Deleted.
* Source/WebCore/html/shadow/DateTimeFieldElement.h:
* Source/WebCore/html/shadow/DateTimeFieldElements.cpp:
(WebCore::DateTimeDayFieldElement::create):
(WebCore::DateTimeHourFieldElement::create):
(WebCore::DateTimeMeridiemFieldElement::create):
(WebCore::DateTimeMillisecondFieldElement::create):
(WebCore::DateTimeMinuteFieldElement::create):
(WebCore::DateTimeMonthFieldElement::create):
(WebCore::DateTimeSecondFieldElement::create):
(WebCore::DateTimeSymbolicMonthFieldElement::create):
(WebCore::DateTimeYearFieldElement::create):
* Source/WebCore/html/shadow/DateTimeNumericFieldElement.cpp:
(WebCore::DateTimeNumericFieldElement::initialize): Deleted.
* Source/WebCore/html/shadow/DateTimeNumericFieldElement.h:
* Source/WebCore/html/shadow/DateTimeSymbolicFieldElement.cpp:
(WebCore::DateTimeSymbolicFieldElement::initialize): Deleted.
* Source/WebCore/html/shadow/DateTimeSymbolicFieldElement.h:
* Source/WebCore/html/shadow/ShadowPseudoIds.cpp:
(WebCore::ShadowPseudoIds::webkitDateAndTimeValue):
(WebCore::ShadowPseudoIds::webkitDatetimeEditDayField):
(WebCore::ShadowPseudoIds::webkitDatetimeEditHourField):
(WebCore::ShadowPseudoIds::webkitDatetimeEditMeridiemField):
(WebCore::ShadowPseudoIds::webkitDatetimeEditMillisecondField):
(WebCore::ShadowPseudoIds::webkitDatetimeEditMinuteField):
(WebCore::ShadowPseudoIds::webkitDatetimeEditMonthField):
(WebCore::ShadowPseudoIds::webkitDatetimeEditSecondField):
(WebCore::ShadowPseudoIds::webkitDatetimeEditText):
(WebCore::ShadowPseudoIds::webkitDatetimeEditYearField):
* Source/WebCore/html/shadow/ShadowPseudoIds.h:

Canonical link: https://commits.webkit.org/272550@main




More information about the webkit-changes mailing list