[webkit-changes] [WebKit/WebKit] ce71cf: [Unified Text Replacement] Replacing text with dif...

[Richard Robinson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ce71cfe36aeaaf258530276b82c1e84ce957b6c4
      https://github.com/WebKit/WebKit/commit/ce71cfe36aeaaf258530276b82c1e84ce957b6c4
  Author: Richard Robinson <richard_robinson2 at apple.com>
  Date:   2024-02-29 (Thu, 29 Feb 2024)

  Changed paths:
    M Source/WebKit/WebProcess/WebPage/UnifiedTextReplacementController.cpp

  Log Message:
  -----------
  [Unified Text Replacement] Replacing text with differing text lengths causes the text to be replaced incorrectly
https://bugs.webkit.org/show_bug.cgi?id=270264
rdar://123790734

Reviewed by Wenson Hsieh and Megan Gardner.

When replacing the text/content, also ensure the corresponding ranges are updated. To facilitate this,
the temporary selection that was being made is no longer temporary, as it never actually needed to be.

Also remove `using namespace WebCore` for more consistency.

* Source/WebKit/WebProcess/WebPage/UnifiedTextReplacementController.cpp:
(WebKit::replaceTextInRange):
(WebKit::replaceContentsInRange):
(WebKit::findReplacementMarkerByUUID):
(WebKit::UnifiedTextReplacementController::textReplacementSessionDidReceiveReplacements):
(WebKit::UnifiedTextReplacementController::textReplacementSessionDidUpdateStateForReplacement):
(WebKit::UnifiedTextReplacementController::didEndTextReplacementSession):
(WebKit::UnifiedTextReplacementController::textReplacementSessionDidReceiveTextWithReplacementRange):
(WebKit::UnifiedTextReplacementController::textReplacementSessionDidReceiveEditAction):

Canonical link: https://commits.webkit.org/275508@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications