[webkit-changes] [WebKit/WebKit] 616aa2: WebsiteDataStore should know about network process...

Sihui noreply at github.com
Thu Feb 29 11:25:49 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 616aa286262cb1322974b00b1e2652b7f2ca6927
      https://github.com/WebKit/WebKit/commit/616aa286262cb1322974b00b1e2652b7f2ca6927
  Author: Sihui Liu <sihui_liu at apple.com>
  Date:   2024-02-29 (Thu, 29 Feb 2024)

  Changed paths:
    M Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp
    M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp
    M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm

  Log Message:
  -----------
  WebsiteDataStore should know about network process when it is added to the process
https://bugs.webkit.org/show_bug.cgi?id=270241
rdar://120988239

Reviewed by Chris Dumez.

UI process sends all WebsiteDataStores to network process when creating it, but does not notify WebsiteDataStore about
the creation of network process. The result is that WebsiteDataStore does not know network process already exists and
will skip some operations, see the places where m_networkProcess is checked in WebsiteDataStore.cpp. This has caused
problems like tracking prevention flag is not updated correctly in network process.

API test: ResourceLoadStatistics.EnableResourceLoadStatisticsAfterNetworkProcessCreation

* Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::sendCreationParametersToNewProcess):
* Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::setNetworkProcess):
* Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
(TEST):

Canonical link: https://commits.webkit.org/275506@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list