[webkit-changes] [WebKit/WebKit] 126a5c: Unified PDF: Find highlights for PDF content with ...

[Tim Horton]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 126a5c9aa7aa6dca80eb9d9f00ba98c97ac34732
      https://github.com/WebKit/WebKit/commit/126a5c9aa7aa6dca80eb9d9f00ba98c97ac34732
  Author: Tim Horton <thorton at apple.com>
  Date:   2024-02-29 (Thu, 29 Feb 2024)

  Changed paths:
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm

  Log Message:
  -----------
  Unified PDF: Find highlights for PDF content with fills obscure the yellow background
https://bugs.webkit.org/show_bug.cgi?id=270287
rdar://123758797

Reviewed by Sammy Gill.

Because PDFKit doesn't have a concept of "range only painting" like WebKit,
we can't actually depend on knocking out the background to paint the TextIndicator.

As such, we instead do what PDFKit does: put the backgrounds back, and multiply the yellow on top!

Also, fix the snapshot coordinate space, which was broken by a non-find-related
earlier patch.

* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::paintPDFContent):
(WebKit::UnifiedPDFPlugin::textIndicatorForSelection):

Canonical link: https://commits.webkit.org/275501@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications