[webkit-changes] [WebKit/WebKit] caf399: [Skia] Implement support for shadows that ignore t...

Georges Basile Stavracas Neto noreply at github.com
Thu Feb 29 06:00:45 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: caf39945f1d1355f2da6049b919218f0c2b68b7b
      https://github.com/WebKit/WebKit/commit/caf39945f1d1355f2da6049b919218f0c2b68b7b
  Author: Georges Basile Stavracas Neto <feaneron at igalia.com>
  Date:   2024-02-29 (Thu, 29 Feb 2024)

  Changed paths:
    M Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp

  Log Message:
  -----------
  [Skia] Implement support for shadows that ignore transforms
https://bugs.webkit.org/show_bug.cgi?id=270175

Reviewed by Carlos Garcia Campos and Nikolas Zimmermann.

When creating the drop shadow filter, if state.shadowsIgnoreTransforms()
is true, render the drop shadow with trasformed coordinates and blur
radius, by adjusting them against the CTM inverse.

This is enough to make various canvas tests happy. Some of them are still
failing with off-by-one colors, and it's not clear why.

* Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContextSkia::createDropShadowFilterIfNeeded const):

Canonical link: https://commits.webkit.org/275492@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list