[webkit-changes] [WebKit/WebKit] d428a6: [WGSL] shader, validation, parse, must_use:* is failing

Tadeu Zagallo noreply at github.com
Thu Feb 29 05:12:33 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d428a6a8c543d4232fdc38d76bb3d09bfd027dd3
      https://github.com/WebKit/WebKit/commit/d428a6a8c543d4232fdc38d76bb3d09bfd027dd3
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2024-02-29 (Thu, 29 Feb 2024)

  Changed paths:
    A LayoutTests/http/tests/webgpu/webgpu/shader/validation/parse/must_use-expected.txt
    M Source/WebGPU/WGSL/TypeCheck.cpp

  Log Message:
  -----------
  [WGSL] shader,validation,parse,must_use:* is failing
https://bugs.webkit.org/show_bug.cgi?id=270247
rdar://123784798

Reviewed by Mike Wyrzykowski.

We handle the general case for must_use in builtins, but struct constructors
and bitcast needed to be handled separately.

* LayoutTests/http/tests/webgpu/webgpu/shader/validation/parse/must_use-expected.txt: Added.
* Source/WebGPU/WGSL/TypeCheck.cpp:
(WGSL::TypeChecker::visit):
(WGSL::TypeChecker::bitcast):

Canonical link: https://commits.webkit.org/275489@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list