[webkit-changes] [WebKit/WebKit] 0f96a6: [UnifiedPDF] <embed> and <object> PDFs spill out o...

Abrar Rahman Protyasha noreply at github.com
Thu Feb 29 04:33:02 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0f96a6a34a86e64caae90cb4f0bc5349811cba76
      https://github.com/WebKit/WebKit/commit/0f96a6a34a86e64caae90cb4f0bc5349811cba76
  Author: Abrar Rahman Protyasha <a_protyasha at apple.com>
  Date:   2024-02-29 (Thu, 29 Feb 2024)

  Changed paths:
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm

  Log Message:
  -----------
  [UnifiedPDF] <embed> and <object> PDFs spill out of their frames when printed
https://bugs.webkit.org/show_bug.cgi?id=270253
rdar://122500785

Reviewed by Tim Horton.

We never clip the GraphicsContext to be painted in with the clip rect we
pass to paintPDFContent, which causes the PDF content to spill over the
frame border. This patch fixes that.

Note that this is not a problem for non-software painting paths because
when we vend painting responsibilites to PDFKit, they perform the
clipping correctly.

* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::paint):
(WebKit::UnifiedPDFPlugin::paintPDFContent):

Canonical link: https://commits.webkit.org/275487@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list