[webkit-changes] [WebKit/WebKit] e336a8: Avoid calling SynchronousLoadData CompletionHandle...

Matthew Finkel noreply at github.com
Wed Feb 28 14:38:49 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e336a8ca8c960b36c8a74aece5e5a16d08274960
      https://github.com/WebKit/WebKit/commit/e336a8ca8c960b36c8a74aece5e5a16d08274960
  Author: Matthew Finkel <sysrqb at apple.com>
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
    M Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp

  Log Message:
  -----------
  Avoid calling SynchronousLoadData CompletionHandler more than once
https://bugs.webkit.org/show_bug.cgi?id=270030
rdar://109257007

Reviewed by Chris Dumez.

In some situations, a NetworkResourceLoader may call its SynchronousLoadData's
delayedReply CompletionHandler more than once. This change returns early if we
hit that case. I'm leaving the debug assertion so we investigate if this starts
happening frequently.

* Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::sendReplyToSynchronousRequest):

Canonical link: https://commits.webkit.org/275465@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list