[webkit-changes] [WebKit/WebKit] 415bdd: Further remove support for "Search with Spotlight"...

[Tim Horton]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 415bdd37cb7467e4a5798e192a94cf8a6b1d3648
      https://github.com/WebKit/WebKit/commit/415bdd37cb7467e4a5798e192a94cf8a6b1d3648
  Author: Tim Horton <timothy_horton at apple.com>
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
    M Source/WebCore/en.lproj/Localizable.strings
    M Source/WebCore/loader/EmptyClients.cpp
    M Source/WebCore/page/ContextMenuClient.h
    M Source/WebCore/page/ContextMenuController.cpp
    M Source/WebCore/platform/ContextMenuItem.cpp
    M Source/WebCore/platform/ContextMenuItem.h
    M Source/WebCore/platform/LocalizedStrings.h
    M Source/WebCore/platform/cocoa/LocalizedStringsCocoa.mm
    M Source/WebKit/Shared/API/c/WKContextMenuItem.cpp
    M Source/WebKit/Shared/API/c/WKSharedAPICast.h
    M Source/WebKit/UIProcess/WebPageProxy.h
    M Source/WebKit/UIProcess/WebPageProxy.messages.in
    M Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm
    M Source/WebKit/UIProcess/mac/WebPageProxyMac.mm
    M Source/WebKit/WebProcess/WebCoreSupport/WebContextMenuClient.h
    M Source/WebKit/WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm
    M Source/WebKitLegacy/mac/DefaultDelegates/WebDefaultContextMenuDelegate.mm
    M Source/WebKitLegacy/mac/WebCoreSupport/WebContextMenuClient.h
    M Source/WebKitLegacy/mac/WebCoreSupport/WebContextMenuClient.mm
    M Source/WebKitLegacy/mac/WebView/WebHTMLView.mm
    M Source/WebKitLegacy/mac/WebView/WebView.mm
    M Source/WebKitLegacy/mac/WebView/WebViewInternal.h

  Log Message:
  -----------
  Further remove support for "Search with Spotlight" context menu item
https://bugs.webkit.org/show_bug.cgi?id=270242

Reviewed by Megan Gardner.

This context menu item was removed in Snow Leopard timeframe, and the functionality
behind it was broken by sandboxing later on (but still many years ago).

Remove our support, but leave the API in place.

* Source/WebCore/en.lproj/Localizable.strings:
* Source/WebCore/loader/EmptyClients.cpp:
* Source/WebCore/page/ContextMenuClient.h:
* Source/WebCore/page/ContextMenuController.cpp:
(WebCore::ContextMenuController::contextMenuItemSelected):
(WebCore::ContextMenuController::populate):
(WebCore::ContextMenuController::checkOrEnableIfNeeded const):
* Source/WebCore/platform/ContextMenuItem.cpp:
(WebCore::isValidContextMenuAction):
* Source/WebCore/platform/ContextMenuItem.h:
* Source/WebCore/platform/LocalizedStrings.h:
* Source/WebCore/platform/cocoa/LocalizedStringsCocoa.mm:
(WebCore::contextMenuItemTagSearchInSpotlight): Deleted.
* Source/WebKit/Shared/API/c/WKContextMenuItem.cpp:
* Source/WebKit/Shared/API/c/WKSharedAPICast.h:
(WebKit::toAPI):
(WebKit::toImpl):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.messages.in:
* Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::searchWithSpotlight): Deleted.
* Source/WebKit/UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::searchWithSpotlight): Deleted.
* Source/WebKit/WebProcess/WebCoreSupport/WebContextMenuClient.h:
* Source/WebKit/WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
(WebKit::WebContextMenuClient::searchWithSpotlight): Deleted.
* Source/WebKitLegacy/mac/DefaultDelegates/WebDefaultContextMenuDelegate.mm:
(-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
(-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]):
* Source/WebKitLegacy/mac/WebCoreSupport/WebContextMenuClient.h:
* Source/WebKitLegacy/mac/WebCoreSupport/WebContextMenuClient.mm:
(WebContextMenuClient::searchWithSpotlight): Deleted.
* Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:
(toAction):
(toTag):
* Source/WebKitLegacy/mac/WebView/WebView.mm:
(-[WebView _searchWithSpotlightFromMenu:]): Deleted.
* Source/WebKitLegacy/mac/WebView/WebViewInternal.h:

Canonical link: https://commits.webkit.org/275463@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications