[webkit-changes] [WebKit/WebKit] fd792c: Adopt dynamicDowncast<> in WebKit/Shared

Anne van Kesteren noreply at github.com
Wed Feb 28 08:54:53 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fd792cf72092af5479252d3203ffcf11fa1855ae
      https://github.com/WebKit/WebKit/commit/fd792cf72092af5479252d3203ffcf11fa1855ae
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
    M Source/WebKit/Shared/RemoteLayerTree/DynamicContentScalingBifurcatedImageBuffer.mm
    M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.mm
    M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerWithInProcessRenderingBackingStore.mm
    M Source/WebKit/Shared/WebHitTestResultData.cpp
    M Source/WebKit/Shared/WebImage.cpp
    M Source/WebKit/Shared/mac/MediaFormatReader/MediaSampleByteRange.cpp
    M Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm

  Log Message:
  -----------
  Adopt dynamicDowncast<> in WebKit/Shared
https://bugs.webkit.org/show_bug.cgi?id=270216

Reviewed by Chris Dumez.

For security & performance.

* Source/WebKit/Shared/RemoteLayerTree/DynamicContentScalingBifurcatedImageBuffer.mm:
(WebKit::DynamicContentScalingBifurcatedImageBuffer::dynamicContentScalingDisplayList):
* Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.mm:
(WebKit::RemoteLayerBackingStoreCollection::markAllBackingStoreVolatile):
* Source/WebKit/Shared/RemoteLayerTree/RemoteLayerWithInProcessRenderingBackingStore.mm:
(WebKit::handleFromBuffer):
* Source/WebKit/Shared/WebHitTestResultData.cpp:
(WebKit::WebHitTestResultData::WebHitTestResultData):

Includes a drive-by fix to adopt is<Text>.

* Source/WebKit/Shared/WebImage.cpp:
(WebKit::WebImage::bitmap const):
(WebKit::WebImage::createHandle const):
* Source/WebKit/Shared/mac/MediaFormatReader/MediaSampleByteRange.cpp:
(WebKit::MediaSampleByteRange::presentationSize const):
* Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performImmediateActionHitTestAtLocation):

This is a drive-by fix to adopt is<Text>. As
isOverTextInsideFormControlElement() already does its own null check on
innerNode() there's no need to do that twice.

Canonical link: https://commits.webkit.org/275447@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list