[webkit-changes] [WebKit/WebKit] 0687b6: Factor out WEBKIT_{APPEND, PREPEND}_GLOBAL_{C, CXX}_...

[Adrian Perez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0687b6d53df56a1b54cc5fe71323ba1b8fe64bbd
      https://github.com/WebKit/WebKit/commit/0687b6d53df56a1b54cc5fe71323ba1b8fe64bbd
  Author: Adrian Perez de Castro <aperez at igalia.com>
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
    M Source/cmake/OptionsCommon.cmake
    M Source/cmake/WebKitCompilerFlags.cmake

  Log Message:
  -----------
  Factor out WEBKIT_{APPEND,PREPEND}_GLOBAL_{C,CXX}_COMPILER_FLAGS
https://bugs.webkit.org/show_bug.cgi?id=270220

Reviewed by Michael Catanzaro.

Add a new WEBKIT_VAR_ADD_COMPILER_FLAGS() CMake function which can
append, prepend, or set supported C or C++ compiler flags into a
variable. The macros that modify the global flag variables
(CMAKE_C_FLAGS and CMAKE_CXX_FLAGS) are rewritten in terms of the
new function.

For completeness, change one remaining use of check_cxx_compiler_flag()
so ultimately every compiler flag check goes through the
WEBKIT_CHECK_COMPILER_FLAGS() function, which ensures all the checks
go through the same point that ensures the check results get propery
cached.

* Source/cmake/OptionsCommon.cmake: Use WEBKIT_CHECK_COMPILER_FLAGS()
  instead of check_cxx_compiler_flag().
* Source/cmake/WebKitCompilerFlags.cmake: Refactor.

Canonical link: https://commits.webkit.org/275444@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications