[webkit-changes] [WebKit/WebKit] 44a5e9: Add logic to determine hasUAVisualTransition value

Rob Buis noreply at github.com
Wed Feb 28 01:47:21 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 44a5e909d5d7fc8de0c7aa834670a5c5e1a3a33a
      https://github.com/WebKit/WebKit/commit/44a5e909d5d7fc8de0c7aa834670a5c5e1a3a33a
  Author: Rob Buis <rbuis at igalia.com>
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
    A LayoutTests/swipe/pushState-back-swipe-verify-ua-transition-expected.txt
    A LayoutTests/swipe/pushState-back-swipe-verify-ua-transition.html
    M Source/WebCore/dom/Document.cpp
    M Source/WebCore/dom/PopStateEvent.h
    M Source/WebCore/page/Page.h
    M Source/WebKit/UIProcess/ProvisionalPageProxy.cpp
    M Source/WebKit/UIProcess/ProvisionalPageProxy.h
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp
    M Source/WebKit/WebProcess/WebPage/WebPage.h
    M Source/WebKit/WebProcess/WebPage/WebPage.messages.in

  Log Message:
  -----------
  Add logic to determine hasUAVisualTransition value
https://bugs.webkit.org/show_bug.cgi?id=264748

Reviewed by Simon Fraser.

Add logic to determine hasUAVisualTransition value for PopStateEvent when swiping on navigation and add a test to verify this.

Rename FreezeLayerTreeDueToSwipeAnimation/UnfreezeLayerTreeDueToSwipeAnimation messages to the more generic
SwipeAnimationDidStart/swipeAnimationDidEnd, since now it needs to handle both layer tree freezing as well
as detecting the swipe on the Page for hasUAVisualTransition determination.

* LayoutTests/swipe/pushState-back-swipe-verify-ua-transition-expected.txt: Added.
* LayoutTests/swipe/pushState-back-swipe-verify-ua-transition.html: Added.
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::dispatchPopstateEvent):
* Source/WebCore/dom/PopStateEvent.h:
* Source/WebCore/page/Page.h:
(WebCore::Page::setIsInSwipeAnimation):
(WebCore::Page::isInSwipeAnimation const):
* Source/WebKit/UIProcess/ProvisionalPageProxy.cpp:
(WebKit::ProvisionalPageProxy::initializeWebPage):
(WebKit::ProvisionalPageProxy::swipeAnimationDidEnd):
(WebKit::ProvisionalPageProxy::unfreezeLayerTreeDueToSwipeAnimation): Deleted.
* Source/WebKit/UIProcess/ProvisionalPageProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::commitProvisionalPage):
(WebKit::WebPageProxy::navigationGestureWillEnd):
(WebKit::WebPageProxy::navigationGestureDidEnd):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::swipeAnimationDidStart):
(WebKit::WebPage::swipeAnimationDidEnd):
(WebKit::WebPage::freezeLayerTreeDueToSwipeAnimation): Deleted.
(WebKit::WebPage::unfreezeLayerTreeDueToSwipeAnimation): Deleted.
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:

Canonical link: https://commits.webkit.org/275438@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list