[webkit-changes] [WebKit/WebKit] e739d6: Simplify compiler flags checking in Source/ThirdPa...

[Adrian Perez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e739d6576a590c7211f9438c5fa9d54fd4cb1ee6
      https://github.com/WebKit/WebKit/commit/e739d6576a590c7211f9438c5fa9d54fd4cb1ee6
  Author: Adrian Perez de Castro <aperez at igalia.com>
  Date:   2024-02-27 (Tue, 27 Feb 2024)

  Changed paths:
    M Source/ThirdParty/skia/CMakeLists.txt
    M Source/cmake/WebKitCompilerFlags.cmake

  Log Message:
  -----------
  Simplify compiler flags checking in Source/ThirdParty/skia/CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=270162

Reviewed by Michael Catanzaro.

Add new WEBKIT_CHECK_COMPILER_FLAGS and WEBKIT_ADD_COMPILER_FLAGS
functions, which split the existing functionality of the existing
WEBKIT_ADD_TARGET_{C,CXX}_FLAGS macros, making them more generic.
The old macros are kept for now, but implemented in terms of the
new functions.

While at it, the WEBKIT_ADD_COMPILER_FLAGS function was augmented to
support applying flags to SOURCE files and DIRECTORY paths, and a
tweak added to ensure results of checks for flags containing equals
characters (=) are properly cached by CMake to save some time in CMake
re-runs.

* Source/ThirdParty/skia/CMakeLists.txt: Make use of the new
  WEBKIT_CHECK_COMPILER_FLAGS and WEBKIT_ADD_COMPILER_FLAGS functions.
* Source/cmake/WebKitCompilerFlags.cmake: Split and improve
  functionality from the WEBKIT_ADD_TARGET_{C,CXX}_FLAGS macros into
  a new function to check flags and another generic function to apply
  flags to targets, sources, or directories.

Canonical link: https://commits.webkit.org/275430@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications