[webkit-changes] [WebKit/WebKit] 139616: [UnifiedPDF] Drop support for "Search in Spotlight...

[Abrar Rahman Protyasha]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1396165ddee4a1cbc4fc20d14cde7a9a9b39f49e
      https://github.com/WebKit/WebKit/commit/1396165ddee4a1cbc4fc20d14cde7a9a9b39f49e
  Author: Abrar Rahman Protyasha <a_protyasha at apple.com>
  Date:   2024-02-27 (Tue, 27 Feb 2024)

  Changed paths:
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm

  Log Message:
  -----------
  [UnifiedPDF] Drop support for "Search in Spotlight" context menu item
https://bugs.webkit.org/show_bug.cgi?id=269320
rdar://122911045

Reviewed by Tim Horton.

This hasn't worked in a while (cf. rdar://56416395), is missing in
PDFView-based context menu items, and its value is marginal. Let's drop
the plumbing so it's squarely a no-op for now.

Note that we can't get rid of the delegate method implementation since
PDFLayerController calls into it unconditionally, but that can be fixed
at a later point.

* Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:
(-[WKPDFLayerControllerDelegate performSpotlightSearch:]):
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h:
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm:
(WebKit::PDFPluginBase::performSpotlightSearch): Deleted.

Canonical link: https://commits.webkit.org/275426@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications