[webkit-changes] [WebKit/WebKit] 177863: Eliminate calls to bundleForClass: at auxiliary pr...

[bnham]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 17786394fdc1af61ab7521d9cd8322b848a7ce1a
      https://github.com/WebKit/WebKit/commit/17786394fdc1af61ab7521d9cd8322b848a7ce1a
  Author: Ben Nham <nham at apple.com>
  Date:   2024-02-27 (Tue, 27 Feb 2024)

  Changed paths:
    M Source/WebKit/Configurations/BaseTarget.xcconfig
    M Source/WebKit/Shared/AuxiliaryProcess.h
    M Source/WebKit/Shared/Cocoa/AuxiliaryProcessCocoa.mm
    M Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm
    M Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm
    M Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm
    M Source/WebKit/UIProcess/mac/WebProcessProxyMac.mm

  Log Message:
  -----------
  Eliminate calls to bundleForClass: at auxiliary process launch time
https://bugs.webkit.org/show_bug.cgi?id=269874
rdar://120925002

Reviewed by Per Arne Vollan.

Some perf folks want us to eliminate calls to `+[NSBundle bundleForClass:]` that we do at auxiliary
process launch time. To do this, pass the bundle version to the compiler via a preprocessor macro
rather than looking it up dynamically via NSBundle at runtime.

* Source/WebKit/Configurations/BaseTarget.xcconfig:
* Source/WebKit/Shared/AuxiliaryProcess.h:
* Source/WebKit/Shared/Cocoa/AuxiliaryProcessCocoa.mm:
(WebKit::AuxiliaryProcess::isSystemWebKit):
* Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm:
(WebKit::checkFrameworkVersion):
* Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm:
(WebKit::AuxiliaryProcess::isSystemWebKit): Deleted.
* Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm:
(WebKit::ProcessLauncher::finishLaunchingProcess):
* Source/WebKit/UIProcess/mac/WebProcessProxyMac.mm:
(WebKit::WebProcessProxy::shouldAllowNonValidInjectedCode const):

Canonical link: https://commits.webkit.org/275405@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications