[webkit-changes] [WebKit/WebKit] cc42f3: REGRESSION(275377 at main): [Win] GLContext::makeCont...

[Fujii Hironori]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cc42f3bc02dcbb775285515187d926faf241c2f7
      https://github.com/WebKit/WebKit/commit/cc42f3bc02dcbb775285515187d926faf241c2f7
  Author: Fujii Hironori <Hironori.Fujii at sony.com>
  Date:   2024-02-27 (Tue, 27 Feb 2024)

  Changed paths:
    M Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.h

  Log Message:
  -----------
  REGRESSION(275377 at main): [Win] GLContext::makeContextCurrent calls purecall for WebGL tests
https://bugs.webkit.org/show_bug.cgi?id=270186

Unreviewed crash fix.

275377 at main introduced GLContextWrapper class to track the current GL
context. ~GLContextWrapper unsets the current context if it is `this`
context.

GraphicsContextGLTextureMapperANGLE class inherits both
GraphicsContextGLANGLE and GLContextWrapper classes in the following
order.

> class GraphicsContextGLTextureMapperANGLE : public GraphicsContextGLANGLE, public GLContextWrapper {

Thus, destructors are called in the following order

1. ~GraphicsContextGLTextureMapperANGLE
2. ~GLContextWrapper
3. ~GraphicsContextGLANGLE

~GLContextWrapper unsets the current context, but
~GraphicsContextGLANGLE makes `this` context current again.
GLContextWrapper base class should be before GraphicsContextGLANGLE.

* Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.h:

Canonical link: https://commits.webkit.org/275402@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications