[webkit-changes] [WebKit/WebKit] 9e3439: REGRESSION (271515 at main): Bold and Italic keyboard...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9e343906838f775714988ac2c3d6be7d7ef157a3
      https://github.com/WebKit/WebKit/commit/9e343906838f775714988ac2c3d6be7d7ef157a3
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2024-02-27 (Tue, 27 Feb 2024)

  Changed paths:
    M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
    M Tools/TestWebKitAPI/Tests/ios/AutocorrectionTestsIOS.mm

  Log Message:
  -----------
  REGRESSION (271515 at main): Bold and Italic keyboard bar button items in the UCB never update
https://bugs.webkit.org/show_bug.cgi?id=270169
rdar://123328041

Reviewed by Tim Horton.

The changes in 271515 at main were meant to merge functionality in both the public API delegate method
`-textStylingAtPosition:inDirection:` and the UIKit IPI `-fontForCaretSelection` into just the
public API. However, this removed logic for setting symbolic traits on the font descriptor (bold,
italic) with no replacement.

Fix this by reinstating this code, and augmenting an existing API test to exercise this logic.

Test: AutocorrectionTests.FontAtCaretWhenUsingUICTFontTextStyle

* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView textStylingAtPosition:inDirection:]):
* Tools/TestWebKitAPI/Tests/ios/AutocorrectionTestsIOS.mm:
(-[UIFont _test_systemFontWithSize:traits:]):

Canonical link: https://commits.webkit.org/275396@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications