[webkit-changes] [WebKit/WebKit] 75b646: Add NSPopover to _WKWebExtensionAction.

[Timothy Hatcher]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 75b646bd8fd82fcc3457d7c99efb23206a3617ca
      https://github.com/WebKit/WebKit/commit/75b646bd8fd82fcc3457d7c99efb23206a3617ca
  Author: Timothy Hatcher <timothy at apple.com>
  Date:   2024-02-27 (Tue, 27 Feb 2024)

  Changed paths:
    M Source/WebKit/Platform/spi/mac/AppKitSPI.h
    M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionAction.h
    M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionAction.mm
    M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionActionCocoa.mm
    M Source/WebKit/UIProcess/Extensions/WebExtensionAction.h
    M Tools/Scripts/webkitpy/style/checkers/cpp.py
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIAction.mm

  Log Message:
  -----------
  Add NSPopover to _WKWebExtensionAction.
https://webkit.org/b/270126
rdar://problem/123655122

Reviewed by Jeff Miller.

Also remove the ContentSizeDidChange and DidClose notifications, since those things
and handled internally now with the UIViewController and NSPopover paths.

Rename closePopupWebView to closePopup to also better align with the new approach.

* Source/WebKit/Platform/spi/mac/AppKitSPI.h:
* Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionAction.h:
* Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionAction.mm:
(-[_WKWebExtensionAction popupPopover]):
(-[_WKWebExtensionAction closePopup]):
(-[_WKWebExtensionAction closePopupWebView]): Deleted.
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionActionCocoa.mm:
(-[_WKWebExtensionActionWebViewDelegate webViewWebContentProcessDidTerminate:]):
(-[_WKWebExtensionActionWebViewDelegate webViewDidClose:]):
(-[_WKWebExtensionActionViewController _viewControllerDismissalTransitionDidEnd:]):
(-[_WKWebExtensionActionPopover initWithWebExtensionAction:]):
(-[_WKWebExtensionActionPopover dealloc]):
(-[_WKWebExtensionActionPopover popoverWillClose:]):
(-[_WKWebExtensionActionPopover popoverDidClose:]):
(-[_WKWebExtensionActionPopover _otherPopoverWillShow:]):
(WebKit::WebExtensionAction::clearCustomizations):
(WebKit::WebExtensionAction::setPopupPath):
(WebKit::WebExtensionAction::popupPopover):
(WebKit::WebExtensionAction::setPopupPopoverAppearance):
(WebKit::WebExtensionAction::detectPopoverColorScheme):
(WebKit::WebExtensionAction::popupWebView):
(WebKit::WebExtensionAction::readyToPresentPopup):
(WebKit::WebExtensionAction::popupSizeDidChange):
(WebKit::WebExtensionAction::closePopup):
(WebKit::WebExtensionAction::popupDidClose): Deleted.
(WebKit::WebExtensionAction::closePopupWebView): Deleted.
* Source/WebKit/UIProcess/Extensions/WebExtensionAction.h:
(WebKit::WebExtensionAction::popupPopoverAppearance const):
* Tools/Scripts/webkitpy/style/checkers/cpp.py:
(check_identifier_name_in_declaration): Make an exception for _WK prefixed classes.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIAction.mm:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/275391@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications